Conversation
…vent test test_concurrent_futures_with_gevent forks and then calls sys.exit(0) in the child, which re-runs atexit handlers inherited from the parent (notably pytest-cov's coverage save, which walks the entire ddtrace/ tree). Under load this doubled, redundant work can exceed the test's 5s timeout and cause an intermittent hang. Use os._exit(0) instead, which is the standard way to terminate a forked child without re-running parent cleanup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Circular import analysis
|
Codeowners resolved asResolved from the full PR diff against |
Dependency direction analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_concurrent_futures_with_geventforks and then callssys.exit(0)in the child, which re-runs atexit handlers inherited from the parent (notably pytest-cov's coverage save, which walks the entire ddtrace/ tree). Under load this doubled, redundant work can exceed the test's 5s timeout and cause an intermittent hang. Use os._exit(0) instead, which is the standard way to terminate a forked child without re-running parent cleanup.Description
Testing
Risks
Additional Notes