feat(templarfi): add ADA, DOGE, LTC, XRP cross-chain assets via omnichain bridge #18666
feat(templarfi): add ADA, DOGE, LTC, XRP cross-chain assets via omnichain bridge #18666SmolinPavel wants to merge 1 commit intoDefiLlama:mainfrom
Conversation
…a omnichain bridge
📝 WalkthroughWalkthroughThe changes add support for four additional omnichain NEAR tokens (Cardano, Dogecoin, Litecoin, XRP). A helper chain file introduces token-to-balance mappings with decimal specifications, while the templarfi adapter extends its supported chains list and cross-chain token detection to include these assets with corresponding tvl and borrowed exports. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
projects/templarfi/index.js (1)
377-377: Consider updating the methodology string to reflect all supported chains.The methodology currently mentions only "Stellar, Ethereum, Bitcoin" but the adapter now supports Cardano, Dogecoin, Litecoin, XRP, and others.
📝 Suggested update
- methodology: 'TVL is calculated by summing the net borrow asset liquidity (deposits minus outstanding loans) and full collateral deposits for each market deployment. Assets are attributed to their origin chain (Stellar, Ethereum, Bitcoin).', + methodology: 'TVL is calculated by summing the net borrow asset liquidity (deposits minus outstanding loans) and full collateral deposits for each market deployment. Assets are attributed to their origin chain (NEAR, Stellar, Ethereum, Bitcoin, Zcash, Solana, Cardano, Dogecoin, Litecoin, XRP).',🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@projects/templarfi/index.js` at line 377, The methodology string assigned to the methodology property currently lists only "Stellar, Ethereum, Bitcoin"; update that string in projects/templarfi/index.js (the methodology property) to reflect all supported chains (e.g., include Cardano, Dogecoin, Litecoin, XRP, plus Stellar, Ethereum, Bitcoin) or replace the explicit list with a phrase like "all supported chains" to keep it accurate as support expands; ensure the revised sentence retains the original meaning about summing net borrow liquidity and full collateral deposits per market deployment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@projects/templarfi/index.js`:
- Line 377: The methodology string assigned to the methodology property
currently lists only "Stellar, Ethereum, Bitcoin"; update that string in
projects/templarfi/index.js (the methodology property) to reflect all supported
chains (e.g., include Cardano, Dogecoin, Litecoin, XRP, plus Stellar, Ethereum,
Bitcoin) or replace the explicit list with a phrase like "all supported chains"
to keep it accurate as support expands; ensure the revised sentence retains the
original meaning about summing net borrow liquidity and full collateral deposits
per market deployment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 26da14d8-27f5-4142-8ecb-76a8b2a59db4
📒 Files selected for processing (2)
projects/helper/chain/near.jsprojects/templarfi/index.js
|
Hi @RohanNero, Could you please review this PR? Let me know if you need anything from me please. |
Summary
cardano.omft.near,doge.omft.near,ltc.omft.near,xrp.omft.near)projects/helper/chain/near.js(ADA: 6, DOGE: 8, LTC: 8, XRP: 6)detectCrossChainTokenmappings and chain entries inprojects/templarfi/index.js, following the same pattern as the existing BTC and ZEC integrationsSummary by CodeRabbit