feat(lunarbase): sum multiple CurvePMM pools#18678
feat(lunarbase): sum multiple CurvePMM pools#18678NebulaNomadPixel wants to merge 2 commits intoDefiLlama:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant TVL as New TVL(tvl)
participant PoolA as Pool A (CurvePMM)
participant PoolB as Pool B (CurvePMM)
participant API as API
rect rgba(150,200,150,0.5)
Caller->>TVL: invoke tvl(api)
TVL->>PoolA: call address:X / address:Y
PoolA-->>TVL: token addresses
TVL->>PoolB: call address:X / address:Y
PoolB-->>TVL: token addresses
TVL->>TVL: aggregate ownerTokens
TVL->>API: sumTokens({ownerTokens})
API-->>TVL: balances
TVL->>API: getBalances()
API-->>TVL: final balances
TVL-->>Caller: return balances
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The adapter at projects/lunarbase exports TVL: |
|
The adapter at projects/lunarbase exports TVL: |
Summary
This change updates the LunarBase adapter to include one additional CurvePMM pool in the TVL calculation on Base.
What changed
0x0716f359B3Bf8d03A3d9d39c60ba9820a1671B990x6Ccc8223532fff07f47EF4311BEB3647326894AbNotes
No other logic was changed.
The existing calculation pattern remains the same, and this PR only extends the pool list with the new address.
Tested
node test.js projects/lunarbaseSummary by CodeRabbit
New Features
Documentation