Skip to content

Add Ember eY10K, Feather PYUSD0 and Midas mROX vault to RockawayX#18704

Open
Sithey wants to merge 3 commits intoDefiLlama:mainfrom
Sithey:main
Open

Add Ember eY10K, Feather PYUSD0 and Midas mROX vault to RockawayX#18704
Sithey wants to merge 3 commits intoDefiLlama:mainfrom
Sithey:main

Conversation

@Sithey
Copy link
Copy Markdown
Contributor

@Sithey Sithey commented Apr 9, 2026

Add Ember eY10K vault tracking for RockawayX on Ethereum.

Summary by CodeRabbit

  • New Features

    • Added ERC‑4626 vault aggregation to TVL calculations for supported chains, preserving existing chain handlers and including ERC‑4626 vaults.
  • Bug Fixes

    • Updated vault registries: added an Ethereum vault, added a Sei Morpho vault entry, and expanded Solana lending vaults to improve TVL coverage.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6f02497-be60-4603-a346-70ba71c7ceab

📥 Commits

Reviewing files that changed from the base of the PR and between 8f780b8 and 7a88080.

📒 Files selected for processing (1)
  • projects/rockawayx/index.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • projects/rockawayx/index.js

📝 Walkthrough

Walkthrough

Added ERC-4626 TVL aggregation to the RockaWayX adapter by introducing an EMBER_VAULTS set and augmenting per-chain tvl handlers to call any existing chain tvl then sumERC4626Vaults. Also appended a MIDAS_VAULTS entry and added sei.morpho to blockchain configs.

Changes

Cohort / File(s) Summary
RockaWayX adapter & configs
projects/rockawayx/index.js
Imported sumERC4626Vaults; added EMBER_VAULTS (includes ethereum) and loop to override/augment adapterExport[chain].tvl to (optionally) call adapterExport[chain]?.tvl then sumERC4626Vaults({ api, calls: vaults, isOG4626: true }). Appended an address to MIDAS_VAULTS.ethereum and added sei.morpho under configs.blockchains with a vault address. Review points: correct vault addresses, preservation/merging of base TVL results, and isOG4626 flag usage.

Sequence Diagram(s)

sequenceDiagram
    participant Adapter as Adapter
    participant BaseTVL as Existing Chain TVL Handler
    participant ERC4626 as sumERC4626Vaults
    participant Blockchain as Blockchain/API

    Adapter->>BaseTVL: call existing tvl(api) [if exists]
    BaseTVL->>Blockchain: fetch balances/state
    Blockchain-->>BaseTVL: return base TVL
    BaseTVL-->>Adapter: return base TVL
    Adapter->>ERC4626: call sumERC4626Vaults({api, calls: vaults, isOG4626:true})
    ERC4626->>Blockchain: fetch vault token balances & metadata
    Blockchain-->>ERC4626: return vault data
    ERC4626-->>Adapter: return summed ERC‑4626 TVL
    Adapter->>Adapter: merge base TVL + ERC‑4626 TVL and return
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
I hopped through vaults at ember glow,
Counting yields row after row,
ERC‑4626 chimed in tune,
Adapter stitched the evening moon,
Hop, merge, and let the balances grow ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and only mentions the Ember eY10K vault, while the title and code changes reference multiple vaults (Ember, Feather, Midas) across different chains. The description does not comprehensively explain all changes being made. Expand the description to cover all vaults being added (Ember eY10K, Feather PYUSD0, Midas mROX), the chains they are on, and clarify the implementation approach with ERC4626 vault tracking.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes by listing the specific vaults being added (Ember eY10K, Feather PYUSD0, Midas mROX) to RockawayX, which aligns with the actual code modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sithey Sithey marked this pull request as ready for review April 9, 2026 13:41
@llamabutler
Copy link
Copy Markdown

The adapter at projects/rockawayx exports TVL:

solana                    15.51 M
ethereum                  10.95 M
plume_mainnet             7.19 M
etlk                      2.27 M

total                    35.92 M 

@llamabutler
Copy link
Copy Markdown

The adapter at projects/rockawayx exports TVL:

solana                    15.51 M
ethereum                  10.95 M
sei                       9.10 M
plume_mainnet             7.19 M
etlk                      2.27 M

total                    45.02 M 

@Sithey Sithey changed the title Add Ember eY10K and Midas mROX vault to RockawayX Add Ember eY10K, Feather PYUSD0 and Midas mROX vault to RockawayX Apr 9, 2026
@Sithey
Copy link
Copy Markdown
Contributor Author

Sithey commented Apr 9, 2026

also add Feather PYUSD0 vault

@Sithey
Copy link
Copy Markdown
Contributor Author

Sithey commented Apr 9, 2026

add also Marinade USD Vault

@llamabutler
Copy link
Copy Markdown

The adapter at projects/rockawayx exports TVL:

solana                    15.87 M
ethereum                  11.18 M
sei                       9.10 M
plume_mainnet             7.19 M
etlk                      2.27 M

total                    45.62 M 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants