Add Ember eY10K, Feather PYUSD0 and Midas mROX vault to RockawayX#18704
Add Ember eY10K, Feather PYUSD0 and Midas mROX vault to RockawayX#18704Sithey wants to merge 3 commits intoDefiLlama:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded ERC-4626 TVL aggregation to the RockaWayX adapter by introducing an Changes
Sequence Diagram(s)sequenceDiagram
participant Adapter as Adapter
participant BaseTVL as Existing Chain TVL Handler
participant ERC4626 as sumERC4626Vaults
participant Blockchain as Blockchain/API
Adapter->>BaseTVL: call existing tvl(api) [if exists]
BaseTVL->>Blockchain: fetch balances/state
Blockchain-->>BaseTVL: return base TVL
BaseTVL-->>Adapter: return base TVL
Adapter->>ERC4626: call sumERC4626Vaults({api, calls: vaults, isOG4626:true})
ERC4626->>Blockchain: fetch vault token balances & metadata
Blockchain-->>ERC4626: return vault data
ERC4626-->>Adapter: return summed ERC‑4626 TVL
Adapter->>Adapter: merge base TVL + ERC‑4626 TVL and return
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The adapter at projects/rockawayx exports TVL: |
|
The adapter at projects/rockawayx exports TVL: |
|
also add Feather PYUSD0 vault |
|
add also Marinade USD Vault |
|
The adapter at projects/rockawayx exports TVL: |
Add Ember eY10K vault tracking for RockawayX on Ethereum.
Summary by CodeRabbit
New Features
Bug Fixes