Warn on duplicate service BOM refs during BOM processing#5908
Open
Zureno wants to merge 1 commit intoDependencyTrack:masterfrom
Open
Warn on duplicate service BOM refs during BOM processing#5908Zureno wants to merge 1 commit intoDependencyTrack:masterfrom
Zureno wants to merge 1 commit intoDependencyTrack:masterfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Zureno <pranshu21freak@gmail.com>
d16efe4 to
98611e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning log for duplicate service BOM references during BOM ingestion.
The method
distinctComponentsByIdentity(...)already logs a warning when duplicate BOM references are encountered for components. However, the equivalent logic indistinctServicesByIdentity(...)silently ignored duplicate BOM references for services.This change aligns the behavior of service processing with component processing by logging a warning when multiple services share the same BOM reference.
This improves diagnostics when ingesting malformed or incorrectly generated SBOMs and helps operators identify issues with SBOM generators.
Addressed Issue
No existing issue.
Improves consistency and observability in BOM processing.
Additional Details
During BOM ingestion,
BomUploadProcessingTaskdeduplicates both components and services using their identity and BOM reference.For components, the method
distinctComponentsByIdentity(...)already detects and logs a warning when multiple components share the same BOM reference: