Skip to content

Logger fix#207

Merged
zoe-codez merged 2 commits into
mainfrom
logger-fix
Jun 13, 2025
Merged

Logger fix#207
zoe-codez merged 2 commits into
mainfrom
logger-fix

Conversation

@zoe-codez

@zoe-codez zoe-codez commented Jun 13, 2025

Copy link
Copy Markdown
Member

📬 Changes

  • name in log line getting dropped because of bad order of operations
  • adjusted workflows to not delete properties out of log (prevent potentially affecting other log outputs)

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

@zoe-codez zoe-codez requested a review from Copilot June 13, 2025 13:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the logger output by correcting the order of operations so that the 'name' property is preserved in the log line while still removing it from the extra data output, and it also bumps the package version.

  • Corrects log output ordering to include the 'name' property.
  • Adjusts the data extraction for logging properties.
  • Bumps the version in package.json from 25.5.3 to 25.6.1.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/services/logger.service.mts Reorders property extraction to preserve 'name' in the log line and formats extra log details.
package.json Updates the version number to reflect the fix.

Comment thread src/services/logger.service.mts
@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (8ac8f5c) to head (aebc6fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   97.47%   97.60%   +0.13%     
==========================================
  Files          29       29              
  Lines        2293     2298       +5     
  Branches      430      430              
==========================================
+ Hits         2235     2243       +8     
+ Misses         58       55       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zoe-codez zoe-codez merged commit f618778 into main Jun 13, 2025
6 checks passed
@zoe-codez zoe-codez deleted the logger-fix branch June 13, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants