fix(config): strip _-prefixed doc keys from merged config#115
Merged
Conversation
_comments/_purpose/_notes from example configs flowed through the jq merge into REMEMBER_CONFIG. Filter top-level _* keys post-merge so future schema/unknown-key validation isn't tripped. Convention: _* are user-facing docs, never runtime data. Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64.
config.example.json(_comments) andconfig.user.example.json(_purpose,_notes) flowed through thejq -s 'reduce ...'merge into the finalREMEMBER_CONFIG. Harmless today, but would trip future schema / unknown-key validation.Fix: append
with_entries(select(.key | startswith("_") | not))to the merge inscripts/lib-memory-dir.sh— strips top-level_*keys post-merge. Convention:_*keys are user-facing docs, never runtime data.Tests
test_underscore_keys_stripped(TDD: seen red before fix, green after)