Skip to content

Fix typo in the table emu_services - #140

Open
mcantoni wants to merge 1 commit into
DinoTools:masterfrom
mcantoni:fix_typo_ihandler_log_sqlite
Open

mcantoni wants to merge 1 commit into
DinoTools:masterfrom
mcantoni:fix_typo_ihandler_log_sqlite

Conversation

@mcantoni

Copy link
Copy Markdown
Contributor
ISSUE TYPE
  • Bugfix
SUMMARY

This fixes the bug described in #139

@dino-bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@phibos

phibos commented Mar 10, 2018

Copy link
Copy Markdown
Member

There should be some kind of migration path

@phibos phibos added this to the 0.8.0 milestone Mar 14, 2018
@xambroz

xambroz commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

There is one more script needing to fix - modules/python/util/logsql2postgres.py

$ grep -R emu_serivce *
modules/python/util/logsql2postgres.py: emu_serivce,
modules/python/dionaea/logsql.py: """SELECT emu_serivce FROM emu_services LIMIT 1""")
modules/python/dionaea/logsql.py: emu_serivce INTEGER PRIMARY KEY,
modules/python/dionaea/logsql.py: emu_serivce, connection, emu_service_url

@mcantoni

mcantoni commented Apr 6, 2018

Copy link
Copy Markdown
Contributor Author

You are right. What do you think about a new release without the old references?

@phibos phibos modified the milestones: 0.8.0, 0.9.0 Jun 15, 2018
@phibos

phibos commented Jun 17, 2018

Copy link
Copy Markdown
Member

I have reviewed the patch again and I'm unsure if fixing a typo is more important than keep compatibility with external tools.

What do you think?

@mcantoni

Copy link
Copy Markdown
Contributor Author

I agree, we wait. For the moment we close the request.
Thank you

@phibos phibos removed this from the 0.9.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants