Fix grid-area resolution edge cases in resolve_absolute_grid_area - #1167
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix edge cases in
DetailedGridTracksInfo::resolve_absolute_grid_areawhere the resolved area diverged from browser behaviour (verified against Chrome via new generated fixtures):auto. Pseudo-diff:placement .resolve_line_names(...) .into_origin_zero(...) - .map(|p| if line out of [min_line, max_line] { Auto } else { p }) .resolve_absolutely_positioned_grid_tracks() + .map(|line| line.filter(|l| min_line <= l && l <= max_line))grid-column: 3 / 1(swapped lines) and a non-existent named line likefoo / 3(which resolves past the explicit grid end) match Chrome: on a 2-column grid,foo / 3resolves to the area between line 3 and the end padding edge.DetailedGridTracksInfogains apub empty_axis_line: Option<f32>field recording that line's position, used as a fallback before the padding-edge fallback.Context
Extracted from the OOF-hoisting stack (#1147, originally in #1145) since it applies to
mainindependently —resolve_absolute_grid_areaalready exists here. The stack will be restacked without this commit once it lands.Also adds named-line support (
grid-template-columns/rowsline names and named placements) to the gentest fixture format, plus 5 Chrome-generated fixtures covering out-of-range lines, unknown/known named lines, padding-edge lines, and empty grids.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/65c5463061c8403bade7888271d5eeb4
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/65c5463061c8403bade7888271d5eeb4?variant=devin-insiders
Requested by: @nicoburns