Skip to content

ENG-1742 Add max height and scroll for node type menu #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trangdoan982 merged 4 commits into from
May 15, 2026
Merged

ENG-1742 Add max height and scroll for node type menu #1019

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bbfbf4
ENG-1742 Add max height and scroll to node type menu
trangdoan982 May 11, 2026
d8d8646
fix max height for NodeMenu
trangdoan982 May 12, 2026
39abe51
support keyboard-only flow
trangdoan982 May 12, 2026
3dbf464
use Blueprint flip: enabled to position Popover
trangdoan982 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/roam/src/components/DiscourseNodeMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ const NodeMenu = ({
);
const menuRef = useRef<HTMLUListElement>(null);
const [activeIndex, setActiveIndex] = useState(0);

useEffect(() => {
menuRef.current?.children[activeIndex]?.scrollIntoView({
block: "nearest",
});
}, [activeIndex]);
const [isOpen, setIsOpen] = useState(!trigger);

const onSelect = useCallback(
Expand Down Expand Up @@ -259,7 +265,11 @@ const NodeMenu = ({
enforceFocus={false}
onInteraction={trigger ? handlePopoverInteraction : undefined}
content={
<Menu ulRef={menuRef} data-active-index={activeIndex}>
<Menu
ulRef={menuRef}
data-active-index={activeIndex}
className="max-h-[60vh] overflow-y-auto"
>
{discourseNodes.map((item, i) => {
const nodeColor =
formatHexColor(item?.canvasSettings?.color) || "#000";
Expand Down
Loading