ENG-1741 Prevent duplicate keyboard shortcuts for node types#1020
Merged
trangdoan982 merged 2 commits intoMay 19, 2026
Merged
Conversation
- On node creation, skip auto-assigning the first-letter shortcut if it is already taken by any existing node type; leave empty instead - In node settings, validate the shortcut field against all other node types and surface an inline error when a conflict is detected Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
mdroidian
requested changes
May 13, 2026
mdroidian
approved these changes
May 19, 2026
trangdoan982
deleted the
eng-1741-modify-keyboard-shortcut-behavior-for-node-type-dropdown
branch
May 19, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/10168beedb5548b38b716ba59b10138f
Summary
Fixes: ENG-1741
Changes
DiscourseNodeConfigPanel.tsx— collision-aware shortcut auto-assignment on "Add node"NodeConfig.tsx—validateShortcutcallback +shortcutErrorstate wired to the Shortcut text panelTest plan
Cexists) — shortcut should be empty, notCMade with Cursor