Skip to content

ENG-1758 Vitest infrastructure#1038

Merged
maparent merged 2 commits into
mainfrom
eng-1758-vitest-infrastructure
May 18, 2026
Merged

ENG-1758 Vitest infrastructure#1038
maparent merged 2 commits into
mainfrom
eng-1758-vitest-infrastructure

Conversation

@maparent

@maparent maparent commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@linear-code

linear-code Bot commented May 15, 2026

Copy link
Copy Markdown

ENG-1758

@graphite-app

graphite-app Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@supabase

supabase Bot commented May 15, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@maparent
maparent force-pushed the eng-1758-vitest-infrastructure branch 3 times, most recently from ff070f2 to 4a8f9bd Compare May 17, 2026 19:37
@maparent
maparent changed the base branch from main to eng-1762-rewrite-all-supabase-access-as-server-side-components May 17, 2026 19:38
@maparent
maparent force-pushed the eng-1762-rewrite-all-supabase-access-as-server-side-components branch from d511dbe to bbed89c Compare May 18, 2026 11:08
@maparent
maparent force-pushed the eng-1758-vitest-infrastructure branch 3 times, most recently from 8fde609 to a5c951e Compare May 18, 2026 13:33
@maparent
maparent requested a review from mdroidian May 18, 2026 13:38
@mdroidian

mdroidian commented May 18, 2026

Copy link
Copy Markdown
Member

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 18, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5c951e0e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/website/test/setup.integration.ts Outdated
import path from "path";

dotenv.config({
path: path.resolve(__dirname, "../../../packages/database/.env.local"),

@chatgpt-codex-connector chatgpt-codex-connector Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Load the selected database env for integration tests

When a developer follows the documented branch workflow (packages/database/README.md:93) and runs website integration tests with SUPABASE_USE_DB=branch, this setup still hard-codes packages/database/.env.local, so the suite either ignores the requested branch DB and runs against a stale local DB or has no Supabase credentials at all. The app and database package already centralize variant selection in @repo/database/dbDotEnv; the test setup should use that same selection before exporting the NEXT_PUBLIC_* variables.

Useful? React with 👍 / 👎.

@maparent maparent May 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually correct; it would be destructive on branches also. I did make the code follow pattern better.

mdroidian
mdroidian approved these changes May 18, 2026
View reviewed changes

@mdroidian mdroidian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See codex comment

@maparent @claude
Add Vitest integration tests for website group invitation functions
66a8fe4 
Tests createGroup, createGroupInvitation, and acceptGroupInvitation
end-to-end against the local Supabase instance. Also fixes a bug where
createGroupInvitation was JSON.stringify-ing the JSONB payload, causing
accept_group_invitation to silently return false.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@maparent
maparent force-pushed the eng-1758-vitest-infrastructure branch from a5c951e to 66a8fe4 Compare May 18, 2026 16:01
@maparent
maparent changed the base branch from eng-1762-rewrite-all-supabase-access-as-server-side-components to main May 18, 2026 16:01
@maparent
maparent merged commit 1bdcd47 into main May 18, 2026
7 checks passed
@maparent
maparent deleted the eng-1758-vitest-infrastructure branch May 18, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@mdroidian mdroidian mdroidian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maparent @mdroidian