eng-1910-add-no-op-content-resolve-endpoint#1208
Closed
maparent wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 8, 2026 00:44
07b2dc7 to
38c7bec
Compare
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 8, 2026 01:32
38c7bec to
57c9964
Compare
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 8, 2026 01:37
57c9964 to
2caa27e
Compare
maparent
force-pushed
the
eng-2003-add-converter-for-crossappnode-to-localconceptdatainput
branch
from
July 8, 2026 12:15
a60fbe5 to
31feaf3
Compare
Base automatically changed from
eng-2003-add-converter-for-crossappnode-to-localconceptdatainput
to
main
July 8, 2026 12:16
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 8, 2026 12:17
2caa27e to
cc166fd
Compare
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 9, 2026 18:12
cc166fd to
9fcc4aa
Compare
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 10, 2026 00:58
9fcc4aa to
c159c03
Compare
maparent
force-pushed
the
eng-1910-add-no-op-nextjs-content-resolve-endpoint
branch
from
July 10, 2026 12:53
c159c03 to
c8e77f1
Compare
Collaborator
Author
|
This was meant for eng-1909 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-1910: Add no-op Next.js content resolve endpoint
Content and concept upsert, based on cross-app types.
Note: This is ready for review in the sense it's ready for an iteration, we should discuss PR boundaries a bit more. Please focus the review on the PR boundaries, the detailed review can come after.
The PR has two routes, maybe they could be separated.
It introduces a StandaloneContent type for upserting contents outside of concepts, following existing sync functions.
In the loom, I mention an issue with inline authors; but I checked and we do not currently use this anywhere in the sync code.
That said, the upsert_concept route is only useable for nodes, we will expand it when we have checked in the converters for more types.
https://www.loom.com/share/0d11ac2c3dea41e3bfe52141701af5e7