Skip to content

ENG-2029 - Discourse context bleeds out of bounds in sidebar#1228

Merged
mdroidian merged 1 commit into
mainfrom
eng-2029-discourse-context-bleeds-out-of-bounds-in-sidebar
Jul 13, 2026
Merged

ENG-2029 - Discourse context bleeds out of bounds in sidebar#1228
mdroidian merged 1 commit into
mainfrom
eng-2029-discourse-context-bleeds-out-of-bounds-in-sidebar

Conversation

@mdroidian

@mdroidian mdroidian commented Jul 13, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

Before
image

After
image

Open in Devin Review

@mdroidian
Refactor handleTitleAdditions to remove layout parameter and adjust c…
de9dc0e 
…ontainer classes for title additions. Update PublishNodeTitleButton and renderLinkedReferenceAdditions to reflect these changes.
@linear-code

linear-code Bot commented Jul 13, 2026

Copy link
Copy Markdown

ENG-2029

@mdroidian
mdroidian requested a review from sid597 July 13, 2026 04:55
@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jul 13, 2026 4:55am

Request Review

@supabase

supabase Bot commented Jul 13, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mdroidian

mdroidian commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@sid597 reverted changes from #1133 which caused this. Let me know what problem these changes were intended to fix.

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Jul 13, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@mdroidian

mdroidian commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: de9dc0eeee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sid597
sid597 approved these changes Jul 13, 2026
View reviewed changes

@sid597 sid597 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think previously we also had duplicate node alert and that component was inline with the publish button, we wanted both on seperate lines. This is better solution.

@mdroidian
mdroidian merged commit bc07cbf into main Jul 13, 2026
10 checks passed
@mdroidian
mdroidian deleted the eng-2029-discourse-context-bleeds-out-of-bounds-in-sidebar branch July 13, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@sid597 sid597 sid597 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdroidian @sid597