Skip to content

ENG-2030 Discourse context under page title doesn't show up unless overlay is on#1229

Merged
mdroidian merged 1 commit into
mainfrom
eng-2030-discourse-context-under-page-title-doesnt-show-up-unless
Jul 13, 2026
Merged

ENG-2030 Discourse context under page title doesn't show up unless overlay is on#1229
mdroidian merged 1 commit into
mainfrom
eng-2030-discourse-context-under-page-title-doesnt-show-up-unless

Conversation

@mdroidian

Copy link
Copy Markdown
Member

Summary

  • Always render discourse context under the title of discourse-node pages.
  • Keep the Overlay preference scoped to discourse context on page references.

Root cause

The page-title renderer was gated by the same personal preference that enables page-reference overlays, so disabling Overlay unintentionally hid the context beneath page titles too.

Impact

Discourse context now appears beneath page titles in both the main window and sidebar regardless of the page-reference overlay preference.

Validation

  • Roam unit suite: 43 tests passed
  • ESLint: changed file passed

@linear-code

linear-code Bot commented Jul 13, 2026

Copy link
Copy Markdown

ENG-2030

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jul 13, 2026 5:38am

Request Review

@supabase

supabase Bot commented Jul 13, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mdroidian
mdroidian marked this pull request as ready for review July 13, 2026 05:46
@mdroidian

Copy link
Copy Markdown
Member Author

@codex review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 073010b3ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdroidian
mdroidian merged commit 7e058c1 into main Jul 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant