Improve validation result clarity for PDF/A-3 warnings (BR-FX-DE-03)#16
Open
Improve validation result clarity for PDF/A-3 warnings (BR-FX-DE-03)#16
Conversation
Add isPdfValid and isXmlValid fields to PdfFileValidationResponse so callers can distinguish PDF/A warnings from XML errors without parsing the raw validation report XML. Under ZuGFeRD rule BR-FX-DE-03, PDF/A compliance failures are non-fatal warnings for German invoices, so isValid may be true while isPdfValid is false. The new fields make this transparent. The WebUI result card now shows a per-section breakdown (XML invoice, PDF/A-3, Signature) with appropriate icons — amber warning for PDF/A issues with an explanatory note when the overall invoice is still valid.
Invalid invoices now show a red (destructive) toast, valid invoices with PDF/A-3 warnings show amber with a BR-FX-DE-03 note, and fully valid invoices stay green. Also use MinusCircle for absent signatures instead of the misleading warning icon.
zsrdjan
force-pushed
the
feature/15-pdf-sub-validation-ux
branch
from
d6c6def to
65eae80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Summary
isPdfValidandisXmlValidfields toPdfFileValidationResponseso API consumers can distinguish PDF/A warnings from XML errors without parsing the raw validation report XMLMinusCircleicon for absent signatures instead of the misleading warning iconTest plan
isValid: true,isPdfValid: false,isXmlValid: true, amber toast with BR-FX-DE-03 note, amber warning icon next to PDF/A-3 in the result cardMinusCircle(-) next to Signature, not a warning icon