Add type definition

[nadilas]

Addresses #30

[ryan-blunden]

Thanks for the PR @nadilas and I'll review next week.

[nadilas]

Sorry, somehow I missed the imports when creating the patch

[nadilas]

@ryan-blunden any way I can help?

[ryan-blunden]

Sorry about the delay @nadilas. I’ll review this as soon as I can.

[nadilas]

Hey @ryan-blunden, just a reminder, this one probably got lost.

[Piccirello]

Thanks for the PR @nadilas. Adding types to this project is definitely a worthwhile endeavor.

This project has an explicit goal of having zero dependencies. That allows us to ensure that this project does not need to be patched as CVEs are found in external libraries. Unfortunately, this PR introduces a dependency on quicktype-core. Rather than rely on quicktype, I think it'd be preferable to convert this codebase to TS. The relatively small size of this repo should make that goal fairly manageable. I will note that we don't have any dedicated resources focused on this project at the moment, so I can't speak to when that change will occur. We'd definitely welcome a PR if that was something you're interested in.

[nadilas]

Hi @Piccirello, thanks for the update. There might be a misunderstanding this PR adds types to the generated output, so its usage is type-safe, hence the quicktype dependency. and not to this codebase.

If there are no resources on your your end, I’m fine with publishing as a separate package if that’s ok with you.

[ryanleecode]

Hi @Piccirello, thanks for the update. There might be a misunderstanding this PR adds types to the generated output, so its usage is type-safe, hence the quicktype dependency. and not to this codebase.

If there are no resources on your your end, I’m fine with publishing as a separate package if that’s ok with you.

Was this ever published? This is a really important feature

[nadilas]

@ryanleecode it wasn’t. How urgently do you need it?