Lab3#1564
Closed
YeeeeRE wants to merge 53 commits into
Closed
Conversation
Owner
|
А где третья лабораторная? |
Dovgalyuk
requested changes
Nov 28, 2025
| target_link_libraries(Lab3CPP LibraryCPP) | ||
|
|
||
| add_test(NAME TestLab3 COMMAND Lab3CPP ${CMAKE_CURRENT_SOURCE_DIR}/input.txt) | ||
| set_property(TEST TestLab3 PROPERTY PASS_REGULAR_EXPRESSION "4") |
Owner
There was a problem hiding this comment.
Нужно добавить ещё сам маршрут.
|
|
||
| using namespace std; | ||
|
|
||
| typedef pair<int, int> Pos; // q, r |
| return maze; | ||
| } | ||
|
|
||
| bool is_valid(const vector<string>& maze, int q, int r, vector<vector<bool>>& visited) { |
Owner
There was a problem hiding this comment.
Для повторяющихся типов стоит сделать typedef.
| int rows = maze.size(); | ||
| if (rows == 0) return -1; | ||
| int cols = maze[0].size(); | ||
| vector<vector<bool>> visited(rows, vector<bool>(cols, false)); |
Owner
There was a problem hiding this comment.
Без этого массива можно обойтись.
| struct List { | ||
| ListItem *head; | ||
| ListItem *tail; | ||
| size_t size; |
Dovgalyuk
requested changes
Dec 2, 2025
| target_link_libraries(Lab3CPP LibraryCPP) | ||
|
|
||
| add_test(NAME TestLab3 COMMAND Lab3CPP ${CMAKE_CURRENT_SOURCE_DIR}/input.txt) | ||
| set_property(TEST TestLab3 PROPERTY PASS_REGULAR_EXPRESSION "4") |
Owner
|
Тесты не проходят. |
Dovgalyuk
requested changes
Dec 5, 2025
|
|
||
| add_test(NAME TestLab3 COMMAND $<TARGET_FILE:Lab3CPP> ${CMAKE_CURRENT_SOURCE_DIR}/input.txt) | ||
| set_property(TEST TestLab3 PROPERTY PASS_REGULAR_EXPRESSION | ||
| "^6\nPath: \\([0-9]+,[0-9]+\\)( -> \\([0-9]+,[0-9]+\\))*\n$") |
Owner
There was a problem hiding this comment.
Нужно сравнивать выводимую картинку.
Dovgalyuk
requested changes
Dec 8, 2025
| elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| add_compile_options(-fsanitize=address,undefined,leak) | ||
| add_link_options(-fsanitize=address,undefined,leak) | ||
| endif() |
Owner
There was a problem hiding this comment.
Опции компиляции удалять нельзя.
| \ / \ / \ / \ / \ / \ / | ||
| | x | . | . | # | . | . | | ||
| \ / \ / \ / \ / \ / \ / | ||
| | # | x | E | . | . | . | |
Owner
There was a problem hiding this comment.
Тут шаг по диагонали, который не был предусмотрен правилами.
added 2 commits
December 9, 2025 02:49
Dovgalyuk
reviewed
Dec 10, 2025
| void get_neighbors(int r, int dirs[6][2]) { | ||
| dirs[0][0] = 1; dirs[0][1] = 0; | ||
| dirs[1][0] = -1; dirs[1][1] = 0; | ||
| if (r % 2 == 0) { |
Author
There was a problem hiding this comment.
функция для определения координат 6 ячеек вокруг заданной ячейки, чтобы определить, куда перемещаться.
r - номер строки, dirs - массив-матрица. Можно сделать реализацию этой функции в других необходимых функциях, но зачем, если можно сделать её один раз и просто применять, когда потребуется
Owner
There was a problem hiding this comment.
Нужно добавить больше тестов, чтобы убедиться, что это неверный код.
Dovgalyuk
requested changes
Dec 18, 2025
| } | ||
| current_position = predecessors[current_position.first][current_position.second]; | ||
| } | ||
| reverse(path_positions.begin(), path_positions.end()); |
Owner
There was a problem hiding this comment.
Можно не переворачивать, а использовать в нужном порядке.
Owner
|
Принято.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.