feat(fs): implement inotify filesystem event notification - #2164
Open
sparkzky wants to merge 1 commit into
Open
Conversation
Member
|
needs to rebase |
sparkzky
force-pushed
the
feat/inotify
branch
3 times, most recently
from
August 1, 2026 07:01
8fad46f to
05ce40d
Compare
Member
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05ce40d4de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sparkzky
added a commit
to sparkzky/DragonOS
that referenced
this pull request
Aug 8, 2026
…5 P1 + 4 P2) P1 fixes: - Composite mark index key (inode_id, dev_id): prevents FUSE cross-mount event leakage when multiple mounts reuse same inode number. - Remove has_any_watch() gate on File::inotify_parent resolution: watches added after open now correctly receive content events. - Move inode-death (DELETE_SELF/UNMOUNT) destroy before mask subscription filter: prevents watch leak when watch doesn't subscribe to the event. - Cache nlinks before unlink/rename-over: avoids FUSE GETATTR failure after namespace change; uses pre-operation link count for DELETE_SELF. - Rename-over checks displaced nlinks: multiple hardlinks survive. P2 fixes: - Sync IN_ONESHOT field on IN_MASK_ADD (OR semantics). - Dynamic O_NONBLOCK: fcntl(F_SETFL) now works on inotify fds. - EOF reads (len==0) no longer deliver IN_ACCESS. - Reject mask==0 and IN_MASK_ADD|IN_MASK_CREATE as EINVAL. - Skip MOVED events on no-op rename (same dir + same name). Verified: make kernel clean, inotify_dir_watch 2/2 PASS, fuse_core 6/6 PASS. Signed-off-by: sparkzky <sparkhhhhhhhhhh@outlook.com>
Implements inotify (issue DragonOS-Community#2151): the fsnotify core notification layer, the inotify pseudo-device, 4 syscalls (init/init1/add_watch/rm_watch), and VFS write-path hooks for all standard events (create/delete/move/ modify/access/close/attrib/self events). Architecture: - fsnotify/ unified dispatch layer: global (inode_id, dev_id) index, TOTAL_WATCHES atomic fast-path (zero cost when no watches), lock-family separation (global index lock / events lock / wd lock never nested). - inotify.rs device: InotifyInode implements IndexNode + PollableInode, epoll-integrated via LockedEPItemLinkedList, exact inotify_event layout (name field aligned to sizeof(inotify_event)=16, matching Linux ABI). - VFS hooks placed in syscall-core layer (vcore/open/rename_utils/...), NOT per-filesystem: single anchor covers ext4/tmpfs/overlayfs/fuse. Hooks fire only after success and never alter syscall return values. Review fixes incorporated: - Directory watches receive child content events (issue B): IN_MODIFY/ ACCESS/OPEN/CLOSE delivered to parent dir watch with child name. MountFSInode::as_any_ref() returns the inner inode's Any, so use downcast_arc instead of downcast_ref for parent resolution. - Guard DELETE_SELF on hardlink unlink/rename-over: only emit when i_nlink reaches 0, matching Linux fsnotify_link_count() semantics. - Composite mark index key (inode_id, dev_id): prevents FUSE cross-mount event leakage when multiple mounts reuse same inode number. - Remove has_any_watch() gate on File::inotify_parent resolution so watches added after open receive content events. - Tolerate metadata failure after unlink/rename-over (FUSE GETATTR can return ENOENT); cache nlinks before the namespace operation. - SYS_INOTIFY_INIT only registered on x86_64 (generic syscall ABI uses inotify_init1); riscv64/loongarch64 lack the legacy init syscall. - Skip MOVED events on no-op rename; EOF reads no longer deliver IN_ACCESS; reject mask==0 and IN_MASK_ADD|IN_MASK_CREATE. Test: dunitest inotify_dir_watch (2 tests) + inotify_events (6 tests) covering content/namespace/self events, multi-instance, and poll. Design doc: docs/kernel/filesystem/inotify.md Signed-off-by: sparkzky <sparkhhhhhhhhhh@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements inotify (issue #2151): filesystem event notification with
inotify_init1/inotify_add_watch/inotify_rm_watch/read, the full standard event set, epoll integration, and exactinotify_eventABI.Design doc:
docs/kernel/filesystem/inotify.md. Behavior targets Linux 6.6.Architecture (3 layers)
fs/notify/-style): globalinode_id -> Weak<mark>index,TOTAL_WATCHESatomic fast-path (zero cost when no watches), lock-family separation (global index lock / events lock / wd lock never nested). Hooks fire only after success and never alter syscall return values.inotify.rs):InotifyInodeimplementsIndexNode + PollableInode, epoll-integrated viaLockedEPItemLinkedList, exactinotify_eventlayout (name field aligned tosizeof(inotify_event)=16, matching the Linux 6.6 ABI).vcore/open/rename_utils/...), not per-filesystem: a single anchor covers ext4/tmpfs/overlayfs/fuse.What this PR adds beyond the initial implementation
The initial implementation was put through a 3-way adversarial review (independent reviewers) + independent verification. This PR includes both the feature and the resulting fixes:
Directory watches now receive child content events (the primary inotify use case, e.g.
inotifywait -m /dir). Previously only namespace events (create/delete/move) reached directory watches;IN_MODIFY/ACCESS/OPEN/CLOSEon children were silently dropped. Resolved by snapshotting the parent dir + child name once atFileconstruction (gated byhas_any_watchfor zero cost when unused) and routing content events to both the parent (with name) and self watch. This also makesIN_EXCL_UNLINKeffective.Other review fixes (all verified):
TOTAL_WATCHESdouble-count onadd_watch(broke the no-watch fast path).add_watchTOCTOU: concurrent same-inode adds created duplicate marks.IN_EXCL_UNLINKpolarity was inverted.fallocate: restored theoffset+lenoverflow guard removed during theIN_MODIFYrefactor.renameoverwriting an existing target now emitsIN_DELETE/IN_DELETE_SELF(was a ghost-watch leak).RENAME_EXCHANGEnow emits the full 4 namespace events + 2MOVE_SELFwith two cookies.Testing
normal/inotify_dir_watch(directory-watch child content events + self-watch sanity), added to the whitelist so CI runs it.make kernel).docs/impl-notes/): rename-after-open yields a stale parent snapshot (EXCL_UNLINK covers unlink);IN_ATTRIB-to-parent via fd-based setattr is not yet wired; unmount does not emitIN_UNMOUNT(watch reclaims on fd close).Checklist
make kernelcompiles