Fix spelling - #1200
Open
SLUCHABLUB wants to merge 113 commits into
Open
Conversation
prep for tailwind upgrade wip wip New design New design
* Add buttongroup * fix lint
* add input and label * fix file upload input * fix formatting
* add pistachio * add badge component * add larger badge * remove unused styles
* Replace default styles for links with utility * Make layout-container utility for intellisense * Turn off no-navigation-without-resolve Our SvelteKit version is too old for this rule. * Update svelte packages Skipped updating vite-plugin-svelte since it requires many more updates * Update devalue patch * Fix type errors from Svelte update
* add textarea component * add editor * move editor file * fix textarea formatting * fix selection * fix selection offset * fix bind * fix prepend * remove comment * fix translations * add translations
* add footer * add translation button to navbar * fix link styles * add address strings * add editor * move editor file * remove unused code * fix editor?? * use simple-icons instead of paths * fix line height for quote * fix footer links * move layout files * add layout to main page
* add radiogroup component * fix formatting * fix destructive
* Add select component * Add CSS variables used by select component * Add destructive color --------- Co-authored-by: Isak Kallini <isak@kallini.se>
* style alert dialog * add dialog component * add separator component * fix alert dialog styling * update styles * add fileupload translations * add file upload component * fix formatting * make fileupload not have fixed width * rename variables, use nicer alt
* Add tabs ui component * Fix tab appearance * Start check * Prettify
* add checkbox component * add checkbox css * fix formatting --------- Co-authored-by: jo4485li-s <jo4485li-s@student.lu.se>
* Add command dialog * Add command dialog part 2 * Ignore svelte/no-navigation-without-resolv * Fix padding * do not wrap event date * fix scroll --------- Co-authored-by: fgren <179166750+fgren@users.noreply.github.com>
* Added icon support for input component * Added DatePicker, TimePicker and DateTimeSelector * Added hidden input elements so DateTimeSelector can be put in form * Add translations to DateTimeSelector & co.
* Install shadcn checkbox * CoiceBox checkbox variant implemented * Made radiobutton * Added checkbox's properties to choicebox * redundant imports * Fixed restprops variable name * Ran format * Fix choicebox checked? Description now option * Can now change props properly
* Add landing page calendar * Landing page calendar done * Make code more cursed * fix lint
* add board page * format * fix mobile design
This makes sure to get the value of the search params and adding / changing them instead of just overwriting them.
davidagardh
self-requested a review
May 25, 2026 22:52
fgren
requested changes
May 28, 2026
fgren
left a comment
fgren
left a comment
Contributor
There was a problem hiding this comment.
I am doubtful of the changes to phaddrar, nollor, nollning and sexet. All of these are established terms and changing them has the risk of introducing bugs and making the code less readable (since the English terms, particularly Mentee and Festivities aren't well-known).
The short-form position ids are always in Swedish and should therefore not be changed to English.
Other changes look good-
* add placeholder debug page * fix datepicker values * add tooltip component * change tooltip delay * update datepicker * add props to memberselector * add positions * fix datetimeselector * fix types * fix types * fix types * change props ordering * rename prop for consistency * move badge to component * give name feedback * add progress component * fix progress bar * use progress bar * add translations * remove debug * remove unused * fix * disallow end dates before start dates * move positions page to committee layout * fix position links * break out into function * add prefixes * close form on submit * fix * remove loggers * fix format * remove import * fix translation string * simplify * remove comment * rename prop * change function call * fix tooltip * fix translation
davidagardh
removed their request for review
June 8, 2026 21:40
davidagardh
reviewed
Jun 8, 2026
davidagardh
left a comment
davidagardh
left a comment
Contributor
There was a problem hiding this comment.
Consistency and correctness is important, but I think it's more important that we stick to terms that are actually used and understood by the guild's members. I have pointed out the changes I think will be harder for most contributors to understand without context. These words are changed in many more places.
| @@map("drink_item_batch") | ||
| } | ||
|
|
||
| model SexetInventoryValueLog { |
Contributor
There was a problem hiding this comment.
Don't change sexet to festivities committee
| nollaIn PhadderGroup? @relation(fields: [nollningGroupId], references: [id], onDelete: SetNull, onUpdate: NoAction, map: "members_nollning_group_id_foreign") | ||
| pingsFromMe Ping[] @relation("pings_from_memberTomembers") | ||
| pingsToMe Ping[] @relation("pings_to_memberTomembers") | ||
| mentorGroupId String? @map("mentor_group_id") @db.Uuid() |
Contributor
There was a problem hiding this comment.
Don't change phadder to mentor
| DOOR: { | ||
| ...crud("core:access:door"), | ||
| }, | ||
| YRKA: { |
Contributor
There was a problem hiding this comment.
Don't change yrka to move
| }, | ||
| NOLLNING: { | ||
| MANAGE_PHADDER_GROUPS: "nollning:phaddrar:groups:manage", | ||
| INTRODUCTION: { |
Contributor
There was a problem hiding this comment.
Don't change nollning to introduction
| splitGroups.add("*"); // all users | ||
| if (groupList?.length || signedIn) splitGroups.add("_"); // logged in users | ||
| if (classYear && classYear === new Date().getFullYear()) | ||
| splitGroups.add("nolla"); |
Contributor
There was a problem hiding this comment.
Don't change nolla to mentee
| }, | ||
| prisma: ExtendedPrisma, | ||
| ) => { | ||
| const kallarMastare = await prisma.member.findFirstOrThrow({ |
Contributor
There was a problem hiding this comment.
Don't change källarmästare to head of facilities committee
Contributor
Author
|
OK, fair. I understand you viewpoint and will revert the relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Summary
Fixes some spelling mistakes.
🔗 Related issues (if any)
Closes #1186
💬 Other information