Env refactor - #1259
Open
davidagardh wants to merge 5 commits into
Open
Conversation
Private is safe because it's only used on the server side.
davidagardh
force-pushed
the
env-refactor
branch
from
August 19, 2026 12:15
f7bd24f to
72005ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Summary
This PR changes what environment variables we use for minio and fixes some odd choices about other env vars. Minio will now be seperated into a public base url used for constructing URLs and a private endpoint that can have a different url. This allows us to change the deployment to keep traffic between the application and minio inside the cluster instead of doing an unnecessary jump through the ingress.
🔗 Related issues (if any)
Part of my work on PR previews
💬 Other information
See commit messages for some clarification.
Should not be merged until changes in dumbo-m are ready.