This repository was archived by the owner on May 2, 2023. It is now read-only.
Add front page notice box for subscribing to newsletter#58
Open
tewson wants to merge 4 commits into
Open
Conversation
Once dismissed, it won't show again for 24 hours
Member
|
Oh jeez -- completely forgot about this and just accidentally closed along with a few dependabots. Will look! So sorry! |
Author
|
Hey! No worries @brianflanagan. Not sure if the requirements are outdated now but let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brianflanagan I was asked to add a floating dismissible notice for people to subscribe to the newsletter to the front page similar to https://thecurrentla.com/. This PR is sort of my proposal for you to review on how to add it.
Basically, I added a new layout partial for a container element that's fixed to the bottom. I then made a copy of the cookie notice because the existing one is used elsewhere. I put this cookie notice copy and a new newsletter subscribe box to the fixed-bottom container.
I also added a new cookie to make the subscribe box appear only once every 24 hours if the user is not logged in.
I still have to add the actual subscription form to the box, but I just wanted to see what you think first.