Skip to content

DYN-6107: Disable publish online option for non package owner #17200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonstratton merged 3 commits into from
Jun 30, 2026
+18 −11
Merged

DYN-6107: Disable publish online option for non package owner #17200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
807100f
maintainers included in pm payload
ivaylo-matov Jun 30, 2026
aa45230
pm version update
ivaylo-matov Jun 30, 2026
90de88f
copilot comment addressed
ivaylo-matov Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DynamoCoreWpf/DynamoCoreWpf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@

<Target Name="NpmRunBuildPMWizard" BeforeTargets="BeforeBuild">
<PropertyGroup>
<PackageVersion>0.0.27</PackageVersion>
<PackageVersion>0.0.28</PackageVersion>
<PackageName>PackageManagerWizard</PackageName>
</PropertyGroup>
<Exec Command="$(PowerShellCommand) -ExecutionPolicy Bypass -File &quot;$(SolutionDir)pkgexist.ps1&quot; &quot;$(PackageName)&quot; &quot;$(PackageVersion)&quot;" ConsoleToMSBuild="true">
Expand Down
27 changes: 17 additions & 10 deletions ...CoreWpf/Views/PackageManager/Components/PackageManagerWizard/PackageManagerWizard.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,23 +543,30 @@ private async void SendPackageUpdates(PublishPackageViewModel vm)
var jsonSerializer = Newtonsoft.Json.JsonSerializer.Create(jsonSerializerSettings);
var rootObj = JObject.FromObject(payload, jsonSerializer);

// Include payload.versions[*].compatibility_matrix for the "Copy from" dropdown.
try
if (rootObj["payload"] is JObject payloadObj)
{
var header = await TryGetPackageHeaderAsync(vm);
if (header != null)
// Present with safe defaults so the frontend always has a consistent shape
payloadObj["versions"] = new JArray();
payloadObj["maintainers"] = new JArray();

try
{
if (rootObj["payload"] is JObject payloadObj)
var header = await TryGetPackageHeaderAsync(vm);
if (header != null)
{
payloadObj["versions"] = header.versions != null
? JToken.FromObject(header.versions, jsonSerializer)
? JToken.FromObject(header.versions, jsonSerializer)
: new JArray();

payloadObj["maintainers"] = header.maintainers != null
? JToken.FromObject(header.maintainers, jsonSerializer)
: new JArray();
Comment on lines +561 to +563

@ivaylo-matov ivaylo-matov Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 90de88f

}
}
}
catch (Exception ex)
{
LogMessage(ex);
catch (Exception ex)
{
LogMessage(ex);
}
}

var jsonPayload = rootObj.ToString(Newtonsoft.Json.Formatting.None);
Expand Down
Loading