Skip to content

create eamxx GW atm process#8319

Open
whannah1 wants to merge 69 commits into
masterfrom
whannah/eamxx/create-gwd-atm-proc-rebase
Open

create eamxx GW atm process#8319
whannah1 wants to merge 69 commits into
masterfrom
whannah/eamxx/create-gwd-atm-proc-rebase

Conversation

@whannah1

@whannah1 whannah1 commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds support for the C++ GW drag schemes in EAMxx. Nothing has been validated yet, but we can save this effort for later when ZM and frontogenesis values are available. For now this PR just adds a working GW interface to EAMxx, but keeps it as a stealth feature.

[BFB]

whannah1 added 30 commits April 23, 2026 14:56
@whannah1
add GWD namelist flags
671543e
@whannah1
add cmake target_compile_definitions
5bada3a
@whannah1
update register_physics.hpp
3ee52d2
@whannah1
update gw_common_init_impl.hpp
24d88c5
@whannah1
misc GWD interface updates
7bdd757
@whannah1
misc GW updates
74b6d7b
@whannah1
add GW buffer variables
6fa4f7a
@whannah1
GW interface updates
3bc75af
@whannah1
add eamxx_simple_linear_interp
0f1ae37
@whannah1
gw updates
048dc90
@whannah1
update simple_linear_interp
32f5a46
@whannah1
bug fix
686d60b
@whannah1
more init updates
426f6f3
@whannah1
namelist fix
8b2494e
@whannah1
fix kbotbg
dfe2a9f
@whannah1
fix gw process register bug
eeadd02
@whannah1
more GW updates
a42e81c
@whannah1
update simple_linear_interp
d6d84a2
@whannah1
more GW updates
66d2c93
@whannah1
namelist fix
9aaf69b
@whannah1
various GW init fixes
fa27032
@whannah1
clean up
128b0a7
@whannah1
add calc for z_int and z_mid
5ecf0b5
@whannah1
gw proc updates
dd42000
@whannah1
add comment
317eb05
@whannah1
add hard-coded do_taper default
aefb09e
@whannah1
major updates for buffer and run_impl
2e88b70
@whannah1
more GWD updates
c3b0a8c
@whannah1
bug fix
694af7c
@whannah1
update gw_functions.hpp and eamxx_gw_process_interface.hpp
bc5cf1e
@whannah1 whannah1 requested a review from Copilot May 7, 2026 20:53
Copilot AI reviewed May 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp Outdated
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp
Comment thread components/eamxx/src/physics/gw/impl/gw_convect_init_impl.hpp
Comment thread components/eamxx/src/physics/gw/impl/gw_common_init_impl.hpp
Comment thread components/eamxx/src/physics/gw/impl/gw_front_init_impl.hpp
Comment thread components/eamxx/src/physics/gw/impl/gw_front_init_impl.hpp
Comment thread components/eamxx/src/physics/gw/impl/gw_convect_init_impl.hpp
@whannah1 whannah1 marked this pull request as ready for review May 7, 2026 21:09
@rljacob

rljacob commented May 11, 2026

Copy link
Copy Markdown
Member

Is this actually ready for review? Needs a description added. Else change it to draft.

@rljacob

rljacob commented May 14, 2026

Copy link
Copy Markdown
Member

Shold this be draft?

@rljacob rljacob marked this pull request as draft May 20, 2026 05:58
@whannah1 whannah1 added Atmosphere EAMxx C++ based E3SM atmosphere model (aka SCREAM) labels Jun 15, 2026
@whannah1 whannah1 marked this pull request as ready for review June 15, 2026 19:40
@jgfouca jgfouca added the CI: approved Allow gh actions PR testing on ghci-snl-* machines label Jun 15, 2026
@whannah1 whannah1 requested a review from Copilot June 15, 2026 22:06
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Comment thread components/eamxx/src/physics/gw/impl/gw_front_init_impl.hpp
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp Outdated
Comment thread components/eamxx/src/physics/gw/impl/gw_compute_stress_profiles_and_diffusivities_impl.hpp
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp Outdated
Comment thread components/eamxx/src/physics/gw/eamxx_gw_process_interface.cpp Outdated
Comment thread components/eamxx/src/physics/gw/impl/gw_front_init_impl.hpp
@whannah1 whannah1 added the Stealth PR has feature which, if turned on, could change climate. fka FCC label Jun 18, 2026
@rljacob

rljacob commented Jun 18, 2026

Copy link
Copy Markdown
Member

Verified again. Need to address a few copilot comments.

@whannah1

whannah1 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

After the latest fix to populate the SGH field from the topo file I've verified that the orographic GWD tendencies are reasonably consistent with EAM for a 1-month comparison of ne30 runs (see figure below).

So I feel this PR is ready to be merged once @bartgol or @jgfouca approve.

image

@jgfouca

jgfouca commented Jun 22, 2026

Copy link
Copy Markdown
Member

Do we understand the reason for the failed CI?

@whannah1

whannah1 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Do we understand the reason for the failed CI?

No, I asked about this on slack and Luca had some thoughts, but I don't get why these tests are failing. It seems like it doesn't have anything to do with GW - maybe I need to rebase to make it use the moab coupler by default...?

        The model is using a deprecated method of determining support libraries, please migrate to 'CASE_SUPPORT_LIBRARIES' variable.
        ERROR: /home/runner/_work/E3SM/E3SM/share/build/buildlib.csm_share FAILED, cat /tmp/ERS.ne4pg2_ne4pg2.F2010-SCREAMv1.ghci-snl_gnu.eamxx-prod.C.20260622_152136_qqqsbp/bld/csm_share.bldlog.260622-152153

@jgfouca

jgfouca commented Jun 22, 2026

Copy link
Copy Markdown
Member

@whannah1 , yes, I think rebasing and getting this branch up-to-date is a no brainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartgol bartgol bartgol left review comments

Copilot code review Copilot Copilot left review comments

@jgfouca jgfouca Awaiting requested review from jgfouca

At least 1 approving review is required to merge this pull request.

Assignees

@tcclevenger tcclevenger

Labels

Atmosphere CI: approved Allow gh actions PR testing on ghci-snl-* machines EAMxx C++ based E3SM atmosphere model (aka SCREAM) Stealth PR has feature which, if turned on, could change climate. fka FCC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@whannah1 @rljacob @jgfouca @bartgol @tcclevenger