Skip to content

Change the VariantType model - move publications to separate table - #423

Merged
dglemos merged 4 commits into
mainfrom
update/schema_var_type_v19
Jul 22, 2026
Merged

Change the VariantType model - move publications to separate table#423
dglemos merged 4 commits into
mainfrom
update/schema_var_type_v19

Conversation

@dglemos

@dglemos dglemos commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Improve the way we store variant types.
Create a separate table to store the publications linked to the variants.

Checks

  • gene2phenotype/api/lgd/<g2p_id>/ - variant_type output has same structure
  • update variant types
  • updating same term: the inheritance is replaced with the new values (if empty then new value is empty); publications are appended (if not linked to variant yet)
  • adding new term
  • add new publication with variant types data
  • create new record with variant types data
  • delete variant type from record
  • delete record that has variant type data
  • gene2phenotype/api/activity_logs/
  • merge records

JIRA Ticket

G2P-473


Contributor Checklist

  • The code compiles and runs as expected
  • Relevant unit tests are added or updated
  • All unit tests are passing
  • Code follows the G2P Coding Guidelines
  • Documentation (code comments, confluence, etc.) has been updated as needed

@dglemos
dglemos requested a review from seeta-ramaraju July 16, 2026 10:46
@dglemos
dglemos marked this pull request as ready for review July 16, 2026 10:47

@seeta-ramaraju seeta-ramaraju left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes have been tested.

@dglemos
dglemos merged commit 601e055 into main Jul 22, 2026
6 checks passed
@dglemos
dglemos deleted the update/schema_var_type_v19 branch July 22, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants