Skip to content

Fix pixel breath cross correlation issue #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psomhorst merged 3 commits into from
Dec 12, 2025
Merged

Fix pixel breath cross correlation issue #463

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4552cd7
Merge branch 'main' into develop
psomhorst Dec 8, 2025
dc5b1f1
Skip pixel if no cross correlation peak was found
psomhorst Dec 7, 2025
a347128
Update warning with detail about unstable data.
psomhorst Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eitprocessing/features/pixel_breath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,14 @@ def find_pixel_breaths( # noqa: C901, PLR0912, PLR0915
# find the closest peak to zero lag
peak_lags = lags[lag_range][peaks]
peak_distances = np.abs(peak_lags)
if len(peak_distances) == 0:
# no peaks found, skip pixel
warnings.warn(
f"Skipping pixel ({row}, {col}) because no cross correlation peak found.",
RuntimeWarning,
stacklevel=2,
)
continue
min_peak_distance = np.min(peak_distances)
candidates = peak_lags[peak_distances == min_peak_distance]

Expand Down