bugFix/TK-4065-handeled-invalid-urls#259
Open
Prajwal17Tunerlabs wants to merge 2 commits intoELEVATE-Project:mainfrom
Open
bugFix/TK-4065-handeled-invalid-urls#259Prajwal17Tunerlabs wants to merge 2 commits intoELEVATE-Project:mainfrom
Prajwal17Tunerlabs wants to merge 2 commits intoELEVATE-Project:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds URL-validation to two middlewares that short-circuit with a 400 Changes
Sequence DiagramsequenceDiagram
participant Client
participant RouteConfigInjector as routeConfigInjector
participant TargetPackagesInjector as targetPackagesInjector
participant GlobalErrorHandler as errorHandler
participant Response
Client->>RouteConfigInjector: HTTP Request
alt routeConfig found
RouteConfigInjector->>TargetPackagesInjector: next()
TargetPackagesInjector->>Response: normal handling -> response
else no routeConfig
RouteConfigInjector->>RouteConfigInjector: create Error(status:400, code:INVALID_URL)
RouteConfigInjector->>errorHandler: next(error)
errorHandler->>errorHandler: console.error(err)
errorHandler->>Response: { success: false, message: err.message }
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/middlewares/targetPackagesInjector.js (1)
5-20: Consider extracting duplicated route validation logic.The route lookup and error creation logic (lines 7-19) is nearly identical to
routeConfigInjector.js(lines 6-18). Both middlewares:
- Construct
baseURLand parse the URL- Find
routeConfigusingmatchPathsAndExtractParams- Create the same error object when not found
Extracting this into a shared utility would reduce duplication and ensure consistent behavior.
♻️ Example shared utility
// src/utils/routeConfigLookup.js const { routesConfigs } = require('@root/configs/routesConfigs') const { matchPathsAndExtractParams } = require('@utils/patternMatcher') exports.findRouteConfig = (req) => { const baseURL = req.protocol + '://' + req.headers.host + '/' const parsedUrl = new URL(req.originalUrl, baseURL) const urlWithoutQuery = parsedUrl.pathname return routesConfigs.routes.find((route) => matchPathsAndExtractParams(route.sourceRoute, urlWithoutQuery) ) } exports.createInvalidUrlError = () => { const error = new Error('Invalid URL') error.status = 400 error.code = 'INVALID_URL' return error }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/middlewares/targetPackagesInjector.js` around lines 5 - 20, Extract the duplicated route lookup and error creation into a shared utility (e.g., findRouteConfig and createInvalidUrlError) and replace the logic inside targetPackagesInjector with calls to that utility; specifically, move the baseURL/URL parsing + routesConfigs.routes.find(...) usage that uses matchPathsAndExtractParams into findRouteConfig(req) and move the Error('Invalid URL') with status/code into createInvalidUrlError(), then update targetPackagesInjector to call findRouteConfig(req) to get routeConfig and, if falsy, return next(createInvalidUrlError()); do the same refactor for routeConfigInjector so both middlewares share the new utility.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app.js`:
- Around line 63-72: The global error handler (the app.use((err, req, res, next)
=> { ... }) block) currently returns err.message directly which may leak
internal info from library errors (see jsonBodyParserWithErrors.js); change the
handler to distinguish controlled/operational errors from unknown errors (e.g.,
check a flag like err.isOperational or a safeMessage property set by
jsonBodyParserWithErrors) and only return the original message for controlled
errors; for all other/untrusted errors return a generic message such as
"Internal Server Error" while still logging the full err (console.error or
processLogger) for diagnostics, and update jsonBodyParserWithErrors to mark
parse errors as controlled (set err.isOperational or err.safeMessage) if needed.
---
Nitpick comments:
In `@src/middlewares/targetPackagesInjector.js`:
- Around line 5-20: Extract the duplicated route lookup and error creation into
a shared utility (e.g., findRouteConfig and createInvalidUrlError) and replace
the logic inside targetPackagesInjector with calls to that utility;
specifically, move the baseURL/URL parsing + routesConfigs.routes.find(...)
usage that uses matchPathsAndExtractParams into findRouteConfig(req) and move
the Error('Invalid URL') with status/code into createInvalidUrlError(), then
update targetPackagesInjector to call findRouteConfig(req) to get routeConfig
and, if falsy, return next(createInvalidUrlError()); do the same refactor for
routeConfigInjector so both middlewares share the new utility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c87c7cbc-4df3-4605-877c-0e66fd3a3c61
📒 Files selected for processing (3)
src/app.jssrc/middlewares/routeConfigInjector.jssrc/middlewares/targetPackagesInjector.js
Comment on lines
+63
to
+72
| app.use((err, req, res, next) => { | ||
| console.error('Global Error Handler:', err); | ||
|
|
||
| const status = err.status || err.statusCode || 500; | ||
|
|
||
| res.status(status).json({ | ||
| success: false, | ||
| message: err.message || 'Internal Server Error' | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Potential information disclosure via err.message for uncontrolled errors.
While this handler works well for controlled errors like 'Invalid URL', it exposes err.message directly in the response. From src/middlewares/jsonBodyParserWithErrors.js (lines 8-12), non-JSON parsing errors are passed through next(err) and will reach this handler. Body-parser and other library errors can contain internal details (stack traces, file paths, or implementation specifics) that should not be exposed to clients.
Consider sanitizing the message for non-controlled errors:
🛡️ Proposed fix to prevent information leakage
app.use((err, req, res, next) => {
console.error('Global Error Handler:', err);
const status = err.status || err.statusCode || 500;
+
+ // Only expose message for known/controlled errors
+ const safeMessage = err.code === 'INVALID_URL'
+ ? err.message
+ : (status < 500 ? err.message : 'Internal Server Error');
res.status(status).json({
success: false,
- message: err.message || 'Internal Server Error'
+ message: safeMessage
});
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| app.use((err, req, res, next) => { | |
| console.error('Global Error Handler:', err); | |
| const status = err.status || err.statusCode || 500; | |
| res.status(status).json({ | |
| success: false, | |
| message: err.message || 'Internal Server Error' | |
| }); | |
| }); | |
| app.use((err, req, res, next) => { | |
| console.error('Global Error Handler:', err); | |
| const status = err.status || err.statusCode || 500; | |
| // Only expose message for known/controlled errors | |
| const safeMessage = err.code === 'INVALID_URL' | |
| ? err.message | |
| : (status < 500 ? err.message : 'Internal Server Error'); | |
| res.status(status).json({ | |
| success: false, | |
| message: safeMessage | |
| }); | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/app.js` around lines 63 - 72, The global error handler (the app.use((err,
req, res, next) => { ... }) block) currently returns err.message directly which
may leak internal info from library errors (see jsonBodyParserWithErrors.js);
change the handler to distinguish controlled/operational errors from unknown
errors (e.g., check a flag like err.isOperational or a safeMessage property set
by jsonBodyParserWithErrors) and only return the original message for controlled
errors; for all other/untrusted errors return a generic message such as
"Internal Server Error" while still logging the full err (console.error or
processLogger) for diagnostics, and update jsonBodyParserWithErrors to mark
parse errors as controlled (set err.isOperational or err.safeMessage) if needed.
VISHNUDAS-tunerlabs
requested changes
Apr 2, 2026
Collaborator
VISHNUDAS-tunerlabs
left a comment
VISHNUDAS-tunerlabs
left a comment
There was a problem hiding this comment.
Reviewed on 2 April
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
New Features