Fix rDateIn >= rDategvd error messages in dshr_stream_mod.F90#353
Merged
Conversation
Fix typos in error messages to match rDateIn >= rDategvd in if test clause
billsacks
reviewed
Sep 18, 2025
billsacks
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing these typos! What would you think about these being changed so that the error messages are written as ">=" instead of the more obscure "ge"? (I realize that you just followed the existing pattern here, so that's not a critique of your changes!)
Contributor
Author
|
Feel free to change it to whatever you prefer. I was only using "ge" to match what was done elsewhere. |
billsacks
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typos in error messages to match rDateIn >= rDategvd in if test clause
Description of changes
Fix typos in error messages to match rDateIn >= rDategvd in if test clause
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial):
no
Any User Interface Changes (namelist or namelist defaults changes):
only error log messages
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
none
Hashes used for testing: