Skip to content

Fix rDateIn >= rDategvd error messages in dshr_stream_mod.F90#353

Merged
billsacks merged 2 commits into
ESCOMP:mainfrom
aekiss:patch-1
Sep 19, 2025
Merged

Fix rDateIn >= rDategvd error messages in dshr_stream_mod.F90#353
billsacks merged 2 commits into
ESCOMP:mainfrom
aekiss:patch-1

Conversation

@aekiss

@aekiss aekiss commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Fix typos in error messages to match rDateIn >= rDategvd in if test clause

Description of changes

Fix typos in error messages to match rDateIn >= rDategvd in if test clause

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):
no

Any User Interface Changes (namelist or namelist defaults changes):
only error log messages

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
none

Hashes used for testing:

Fix typos in error messages to match rDateIn >= rDategvd in if test clause

@billsacks billsacks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these typos! What would you think about these being changed so that the error messages are written as ">=" instead of the more obscure "ge"? (I realize that you just followed the existing pattern here, so that's not a critique of your changes!)

@aekiss

aekiss commented Sep 18, 2025

Copy link
Copy Markdown
Contributor Author

Feel free to change it to whatever you prefer. I was only using "ge" to match what was done elsewhere.

@billsacks billsacks merged commit 95e0bac into ESCOMP:main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants