feat: Add "Edit With" feature to edit artefacts in OpenTheso - #74
Open
Imene-Amirat wants to merge 11 commits into
Open
feat: Add "Edit With" feature to edit artefacts in OpenTheso#74Imene-Amirat wants to merge 11 commits into
Imene-Amirat wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR starts wiring an “Edit With” control into the ontology (semantic artefact) viewer header, adding i18n strings and a new helper-rendered button intended to launch an external editor (e.g., OpenTheso).
Changes:
- Add
application.edit_withandapplication.edit_with_tooltiptranslations (EN/FR). - Render an
edit_with_buttonin the ontology viewer header. - Add an
edit_with_buttonhelper (currently a UI-only stub).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config/locales/fr.yml | Adds French strings for the new “Edit With” UI. |
| config/locales/en.yml | Adds English strings for the new “Edit With” UI. |
| app/views/layouts/ontology_viewer/_header.html.haml | Adds the “Edit With” button to the ontology header. |
| app/helpers/ontologies_helper.rb | Introduces edit_with_button; modifies submission/edit button helpers (currently with authorization regressions). |
Comments suppressed due to low confidence (1)
app/helpers/ontologies_helper.rb:686
new_submission_buttonno longer checks@ontology.admin?(session[:user]), so the “Add new submission” action becomes visible to non-admin users. This is a UI authorization regression (even if the controller still enforces permissions).
def new_submission_button
return unless @ontology.admin?(session[:user])
render RoundedButtonComponent.new(link: new_ontology_submission_path(@ontology.acronym), icon: 'icons/plus.svg',
size: 'medium', title: t('ontologies.add_new_submission'))
end
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "Edit With" button to edit semantic artefacts in an external editor #73