Skip to content

feat: Add "Edit With" feature to edit artefacts in OpenTheso - #74

Open
Imene-Amirat wants to merge 11 commits into
developmentfrom
feature/edit-with-opentheso
Open

feat: Add "Edit With" feature to edit artefacts in OpenTheso#74
Imene-Amirat wants to merge 11 commits into
developmentfrom
feature/edit-with-opentheso

Conversation

@Imene-Amirat

Copy link
Copy Markdown
Collaborator

@Imene-Amirat
Imene-Amirat requested a review from hakimalem June 17, 2026 14:06
@Imene-Amirat Imene-Amirat self-assigned this Jun 17, 2026
Copilot AI review requested due to automatic review settings June 17, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR starts wiring an “Edit With” control into the ontology (semantic artefact) viewer header, adding i18n strings and a new helper-rendered button intended to launch an external editor (e.g., OpenTheso).

Changes:

  • Add application.edit_with and application.edit_with_tooltip translations (EN/FR).
  • Render an edit_with_button in the ontology viewer header.
  • Add an edit_with_button helper (currently a UI-only stub).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
config/locales/fr.yml Adds French strings for the new “Edit With” UI.
config/locales/en.yml Adds English strings for the new “Edit With” UI.
app/views/layouts/ontology_viewer/_header.html.haml Adds the “Edit With” button to the ontology header.
app/helpers/ontologies_helper.rb Introduces edit_with_button; modifies submission/edit button helpers (currently with authorization regressions).
Comments suppressed due to low confidence (1)

app/helpers/ontologies_helper.rb:686

  • new_submission_button no longer checks @ontology.admin?(session[:user]), so the “Add new submission” action becomes visible to non-admin users. This is a UI authorization regression (even if the controller still enforces permissions).
  def new_submission_button
    return unless @ontology.admin?(session[:user])
    render RoundedButtonComponent.new(link: new_ontology_submission_path(@ontology.acronym), icon: 'icons/plus.svg',
                                      size: 'medium', title: t('ontologies.add_new_submission'))
  end

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/helpers/ontologies_helper.rb
Comment thread app/helpers/ontologies_helper.rb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants