Add AttributePage, RadioButton, ComboBox#241
Open
Ghabry wants to merge 10 commits intoEasyRPG:masterfrom
Open
Conversation
Something simple to get started
This requires filtering the Equipment list. We already had a filter model for this. The change was just a bit more involved because the ActorModel must be a value type to be usable as a Q_GADGET.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR to show that the editor is not dead again :P.
Notable changes are:
A fully working Attributes Page (RM calls this Elements). Not that this page is very useful but it was a good test case for implementing
Ez.RadioButton(+ JSON binding) and learning aboutRepeater.Ez.ComboBoxwith support of binding to aJsonList(ignore the mixed width of the Comboboxes, I'll fix layout issues later). The nice part: For the equipment I was able to reuse the "IdListFilter" that was already used to filter in the QWidgets Database.The JsonList can contain now an optional "None" element.
And besides
JsonListit can also bind to a normal value+text model.Rest is mostly cleanup and bugfixes (the
.clangdis the config file for clangd used by multiple IDEs). The default config doesn't work, probably Qt pulling in some weird flags.