Add rectangular HVAC duct elbows#50
Open
gitgrahamdunn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuctElbowparametric object with editable width, height, wall thickness, bend angle, and centerline bend radiusDuctElbow_Rectangular.csvwith common metric rectangular duct elbow presets in 45-degree and 90-degree variantsInsert duct elbowcommand/form and wires it into the piping toolbarAdd HVAC duct support -> Elbowcomplete in the roadmapSource Data
23 3114 - Ductwork: https://www.northwestern.edu/facilities/docs/construction/design_guidelines/23_hvac/NU_23%203114%20-%20DUCTWORK.pdfPreview
Validation
python3 -m py_compile pFeatures.py pCmd.py pForms.py CPipe.py InitGui.py Quetzal_tooltips.pygit diff --checkDuctElbowandpCmd.makeDuctElbow: both produced one solid with nonzero volume and two ports