fix(Table): add scroll tolerance so Scroller arrows reach the last column at fractional zoom - #1140
Merged
Merged
Conversation
…lumn at fractional zoom
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 84.45% 84.95% +0.50%
==========================================
Files 1230 1230
Lines 21533 21527 -6
Branches 8176 8171 -5
==========================================
+ Hits 18185 18288 +103
+ Misses 3262 3153 -109
Partials 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
agupta-eightfold
approved these changes
Jul 2, 2026
agupta-eightfold
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, just a minor fix pending, please check.
…rance Replace the exact-equality scroll-extent checks in onBodyScroll with a 1px tolerance, so fractional-zoom subpixel rounding no longer leaves the end arrow visible and clickable at the scroll end. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
The horizontal scroll arrow buttons on
<Table showScroller>can't scroll all the way to the last columns at browser zoom below 100% (e.g. 90%). The bottom scrollbar/slider works fine — only the arrow buttons fall short.Root cause
The
Scrollerbuilds its scroll stop-points from the declared column widths (e.g. 128px), advancing withscrollOffsets.find(offset => offset > scrollLeft). At fractional zoom the browser snaps each 128px column to a slightly smaller rendered value (~127.78px at 90% / DPR 1.8) while the stop-points stay integer. So after a click targeting 128 the body settles at 127.78, and the next click'sfind(offset => offset > 127.78)returns 128 again → scrolling snaps right back → the arrow is stuck. At 100% zoom rendered width == declared width, which is why it only reproduces below 100%.This is a generic Octuple bug affecting any table using
showScrollerwith fixed-pixel columns.Fix
Add a 1px tolerance in
Scroller'sonClickso the comparison skips theboundary the scroller is already snapped to:
offset > scrollLeft + 1offset < scrollLeft - 1GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-199352
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Tested locally -
Screen.Recording.2026-07-02.at.8.14.42.PM.mov