fix(DatePicker): make underline variant border override order-independent - #1154
Merged
agupta-eightfold merged 1 commit intoJul 14, 2026
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…dent
The underline variant relied on datepicker.module.scss's
.picker-underline { border-color: transparent } outranking the base
.picker { border: var(--picker-border) } from ocpicker.module.scss.
Both selectors have equal specificity, so the winner was decided by
CSS emission order in the consuming app's webpack build — which is
derived from the app-wide import graph and can flip on unrelated
changes (mini-css-extract conflicting-order resolution). When it
flips, the box border reappears around underline-sized content and
clips the suffix calendar icon.
Declare border-color: transparent inside ocpicker.module.scss's own
.picker-underline block, where same-file source order guarantees it
always follows the base .picker rule regardless of bundler ordering.
Covers DatePicker, TimePicker and RangePicker (shared internal styles).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
agupta-eightfold
force-pushed
the
agupta/datepicker-underline-order-independent
branch
from
July 14, 2026 10:24
d41e015 to
e915813
Compare
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 85.00% 85.01%
=======================================
Files 1230 1230
Lines 21588 21588
Branches 8209 8209
=======================================
+ Hits 18351 18352 +1
+ Misses 3151 3150 -1
Partials 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Underline picker variant hides the box border via
datepicker.module.scss.picker-underline { border-color: transparent }, which ties on specificity with.picker { border: ... }inInternal/ocpicker.module.scss— so the winner depends on the consuming app's CSS emission order, which webpack can flip on unrelated changes. When flipped, the box border reappears and clips the suffix calendar icon (seen on stage scheduling panel; QA unaffected on the same octuple version).Fix: declare
border-color: transparentin ocpicker.module.scss's own&-underlineblock — same-file order always puts it after the base rule, making the override bundler-order-proof. Covers DatePicker/TimePicker/RangePicker.GITHUB ISSUE (Open Source Contributors)
N/A
JIRA TASK (Eightfold Employees Only):
TBD
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
shape=underline, date selected — underline only, no box border, suffix icon fully visible. ✅🤖 Generated with Claude Code