Skip to content

fix: replace 9 bare except clauses with except Exception#1374

Closed
haosenwang1018 wants to merge 1 commit intoEleutherAI:mainfrom
haosenwang1018:fix/bare-excepts
Closed

fix: replace 9 bare except clauses with except Exception#1374
haosenwang1018 wants to merge 1 commit intoEleutherAI:mainfrom
haosenwang1018:fix/bare-excepts

Conversation

@haosenwang1018
Copy link
Copy Markdown

What

Replace 9 bare except: clauses with except Exception:.

Why

Bare except: catches BaseException, including KeyboardInterrupt and SystemExit, which can prevent clean process shutdown and mask critical errors. Using except Exception: catches all application-level errors while allowing system-level exceptions to propagate correctly.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@haosenwang1018
Copy link
Copy Markdown
Author

Closing per backlog policy; can split into smaller reviewable changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants