fix: barman-to-barman sync for incremental backups (#1115)#1159
Open
jonatas-rp wants to merge 1 commit into
Open
fix: barman-to-barman sync for incremental backups (#1115)#1159jonatas-rp wants to merge 1 commit into
jonatas-rp wants to merge 1 commit into
Conversation
When syncing incremental backups from a primary barman server to a passive barman server, a KeyError was raised in is_backup_locally_obsolete because the parent backup info did not contain the reference to the children_backup_ids and the field was not loaded correctly when building a BackupInfo object. Changes: - Added sync_parent_backup_info method to Server class - Call sync_parent_backup_info in sync_cron before check_sync_required - Fixed children_backup_ids deserialization in BackupInfo.from_json - Added comprehensive tests for sync_parent_backup_info
|
I think this change does not deal with the situation where you have synced backups that are beyond the retention period on the primary? So even when this change gets merged, the only way to cleanup an existing barman backup server is to rerun the sync from scratch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix barman-to-barman sync for incremental backups #1115
When syncing incremental backups from a primary barman server to a passive barman server, a KeyError was raised in is_backup_locally_obsolete because the parent backup info did not contain the reference to the children_backup_ids and the field was not loaded correctly when building a BackupInfo object.
Changes: