lore-server: Support file:// JWKS endpoints in JWK service by kidskoding · Pull Request #44 · EpicGames/lore

kidskoding · 2026-06-20T14:58:16Z

Summary

Fixes #32

Added a scheme check in fetch_new_keys() that checks for either file:// or http:// (https://)

If http:// or https://, nothing changes - same network fetch as before
If it's a file://, open the path on disk and read contents directly (implemented via tokio::fs::read_to_string instead of communicating over HTTP)

Test Plan

Added two tests covering the new file-read path: one verifies keys load correctly from a file:// endpoint and the other confirms a missing file still fails cleanly

Ran Tests: cargo test -p lore-server auth::jwk:: — both loads_keys_from_file_url and file_url_missing_file_returns_error - PASS
Format, Build, and Pre-commit - Formatted via clippy and cargo nightly formatter; Built via cargo build; pre-commit tool ran
- cargo +nightly fmt --all
- cargo clippy --all-targets -- -D warnings --no-deps
- cargo build — all clean (no error)
- pre-commit run --all-files — clean

kidskoding · 2026-06-21T14:46:25Z

maintainers / someone please review - @ragnarula @mjansson

peter-lockhart-pub

Thank you very much for the contribution, this looks good to me. Can I be a bit pedantic please; could you move the .gitignore change to another PR? Just so the commit remains meticulous and free from unrelated changes?

kidskoding · 2026-06-22T08:55:16Z

sure thing! accidentally stashed all changes at once!

kidskoding · 2026-06-22T09:07:47Z

@peter-lockhart-pub please review again, along with #50!

peter-lockhart-pub

Thanks!

kidskoding · 2026-06-22T09:21:42Z

Maintainers may need to reapprove CI/CD workflows due to a force push of commits on existing fork, intended to align with relevant PR titles - @mjansson, @peter-lockhart-pub

peter-lockhart-pub · 2026-06-22T14:32:06Z

Maintainers may need to reapprove CI/CD workflows due to a force push of commits on existing fork, intended to align with relevant PR titles - @mjansson, @peter-lockhart-pub

Done! This PR will be picked up by another process that will merge it now that it is approved and good to go

Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com>

Per review feedback, the file:// and http(s):// JWKS load paths shared one generic parse-error warning. Split it so the file case logs "invalid JWKS file contents" and the remote case keeps "failed to parse JWKS response". Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com>

mjansson · 2026-07-07T12:26:46Z

We'll get this merged once the intake and attribution process is in place, ideally early next week.

kidskoding · 2026-07-14T19:19:13Z

sounds good! thank you! updated fork so looks like PR has updated merge commit in order to sync fork to upstream

@peter-lockhart-pub

Upon request in #44 thread by @peter-lockhart-pub Local Claude Code skills and settings live under .claude/ and shouldn't be tracked. The prior rule only covered one skill subdirectory; broaden it to the whole directory Just an fyi, these skills that were gitignored are used to help assist in the codebase, such as finding good issues to tackle and understanding what the codebase does from a technical standpoint. Some do assist in code, where disclaimers will be written when done so, but code will still carefully be checked, reviewed, and tested via a human before sending in a PR ``` Imported-PR: #50 Imported-From: 46da301 Imported-Base: a00b1c4 Imported-Merge: 9595422 Imported-Author: Anirudh Konidala Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com> GH-URL: #50 ``` Lore-RevId: 316 Lore-Signature: 19ef4eb8b9d9a88b8fe719aa4ebae4e4ba91378645848dc2a255cdff96a89203

epic-lore-bot · 2026-07-28T19:13:30Z

Imported as Lore CR-256.

epic-lore-bot · 2026-07-29T07:21:27Z

Closed by mirrored commit ed0299b.

# Summary Fixes #32 Added a scheme check in `fetch_new_keys()` that checks for either file:// or http:// (https://) - If http:// or https://, nothing changes - same network fetch as before - If it's a file://, open the path on disk and read contents directly (implemented via `tokio::fs::read_to_string` instead of communicating over HTTP) ## Test Plan Added two tests covering the new file-read path: one verifies keys load correctly from a file:// endpoint and the other confirms a missing file still fails cleanly - **Ran Tests**: cargo test -p lore-server auth::jwk:: — both loads_keys_from_file_url and file_url_missing_file_returns_error - PASS - **Format, Build, and Pre-commit** - Formatted via clippy and cargo nightly formatter; Built via cargo build; pre-commit tool ran - cargo +nightly fmt --all - cargo clippy --all-targets -- -D warnings --no-deps - cargo build — all clean (no error) - pre-commit run --all-files — clean ``` Imported-PR: #44 Imported-From: 084b461 Imported-Base: 71173f3 Imported-Merge: ff95c30 Imported-Author: Anirudh Konidala Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com> GH-URL: #44 ``` Lore-RevId: 370 Lore-Signature: f0f1a87ed1968bc52557dfc4f9decca59c680d0a7535daa8440d2ecdcb5fd723

# Summary Fixes EpicGames#32 Added a scheme check in `fetch_new_keys()` that checks for either file:// or http:// (https://) - If http:// or https://, nothing changes - same network fetch as before - If it's a file://, open the path on disk and read contents directly (implemented via `tokio::fs::read_to_string` instead of communicating over HTTP) ## Test Plan Added two tests covering the new file-read path: one verifies keys load correctly from a file:// endpoint and the other confirms a missing file still fails cleanly - **Ran Tests**: cargo test -p lore-server auth::jwk:: — both loads_keys_from_file_url and file_url_missing_file_returns_error - PASS - **Format, Build, and Pre-commit** - Formatted via clippy and cargo nightly formatter; Built via cargo build; pre-commit tool ran - cargo +nightly fmt --all - cargo clippy --all-targets -- -D warnings --no-deps - cargo build — all clean (no error) - pre-commit run --all-files — clean ``` Imported-PR: EpicGames#44 Imported-From: 084b461 Imported-Base: 71173f3 Imported-Merge: ff95c30 Imported-Author: Anirudh Konidala Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com> GH-URL: EpicGames#44 ``` Lore-RevId: 370 Lore-Signature: f0f1a87ed1968bc52557dfc4f9decca59c680d0a7535daa8440d2ecdcb5fd723 (cherry picked from commit ed0299b)

mjansson reviewed Jun 22, 2026

View reviewed changes

Comment thread lore-server/src/auth/jwk.rs Outdated

peter-lockhart-pub reviewed Jun 22, 2026

View reviewed changes

kidskoding force-pushed the main branch 2 times, most recently from b2cdd30 to b6acd90 Compare June 22, 2026 08:58

kidskoding mentioned this pull request Jun 22, 2026

gitignore: Ignore entire .claude/ directory #50

Closed

peter-lockhart-pub approved these changes Jun 22, 2026

View reviewed changes

valentina2509 mentioned this pull request Jun 26, 2026

JWK key-ring loader hardening #78

Closed

Anirudh Konidala added 2 commits July 6, 2026 20:28

lore-server: support file:// JWKS endpoints in JWK service

f1e0507

Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com>

kidskoding force-pushed the main branch from 06e2ec9 to 00dfe9a Compare July 7, 2026 01:29

Merge branch 'EpicGames:main' into main

8ca9e3c

Merge branch 'EpicGames:main' into main

084b461

mjansson added the ready-to-import Approved by Epic staff for import into Lore label Jul 28, 2026

epic-lore-bot Bot added imported Imported into Lore for internal review and removed ready-to-import Approved by Epic staff for import into Lore labels Jul 28, 2026

epic-lore-bot Bot closed this Jul 29, 2026

epic-lore-bot Bot added the merged Merged into Lore codebase label Jul 29, 2026

Navigation Menu

Uh oh!

lore-server: Support file:// JWKS endpoints in JWK service - #44

lore-server: Support file:// JWKS endpoints in JWK service #44
kidskoding wants to merge 4 commits into
EpicGames:mainfrom
kidskoding:main

kidskoding commented Jun 20, 2026

Uh oh!

kidskoding commented Jun 21, 2026

Uh oh!

Uh oh!

peter-lockhart-pub left a comment •

edited

Loading

Uh oh!

kidskoding commented Jun 22, 2026

Uh oh!

kidskoding commented Jun 22, 2026

Uh oh!

peter-lockhart-pub left a comment

Uh oh!

kidskoding commented Jun 22, 2026 •

edited

Loading

Uh oh!

peter-lockhart-pub commented Jun 22, 2026

Uh oh!

mjansson commented Jul 7, 2026

Uh oh!

kidskoding commented Jul 14, 2026

Uh oh!

epic-lore-bot Bot commented Jul 28, 2026

Uh oh!

epic-lore-bot Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kidskoding commented Jun 20, 2026

Summary

Test Plan

Uh oh!

kidskoding commented Jun 21, 2026

Uh oh!

Uh oh!

peter-lockhart-pub left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kidskoding commented Jun 22, 2026

Uh oh!

kidskoding commented Jun 22, 2026

Uh oh!

peter-lockhart-pub left a comment

Choose a reason for hiding this comment

Uh oh!

kidskoding commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peter-lockhart-pub commented Jun 22, 2026

Uh oh!

mjansson commented Jul 7, 2026

Uh oh!

kidskoding commented Jul 14, 2026

Uh oh!

epic-lore-bot Bot commented Jul 28, 2026

Uh oh!

epic-lore-bot Bot commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

peter-lockhart-pub left a comment •

edited

Loading

kidskoding commented Jun 22, 2026 •

edited

Loading