Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output - #45
Gate windows-sys dependencies on Windows targets and fix UTF-8 terminal output#45subhramit wants to merge 3 commits into
windows-sys dependencies on Windows targets and fix UTF-8 terminal output#45Conversation
Four crates listed `windows-sys` under `[dependencies]`, causing build failures on non-x86_64 Linux architectures. Move them under `[target.'cfg(target_family = "windows")'.dependencies]`. Fixes EpicGames#43 Signed-off-by: subhramit <subhramit.bb@live.in>
mjansson
left a comment
mjansson
left a comment
There was a problem hiding this comment.
Makes sense to me, looks good
subhramit
changed the title
windows-sys dependency under Windows targetswindows-sys dependencies under Windows targets
`lore history` and other pager-backed commands produced mojibake for non-ASCII characters on Windows because the console codepage defaulted to a legacy encoding. Call `SetConsoleOutputCP(CP_UTF8)` at CLI startup under `#[cfg(target_family = "windows")]` so all output, including pager-spawned subprocesses, uses UTF-8 from the start. Fixes EpicGames#30 Signed-off-by: subhramit <subhramit.bb@live.in>
…s-sys-platform-gate
subhramit
changed the title
windows-sys dependencies under Windows targets
|
Extended scope of the PR due to #77 (comment). |
subhramit
changed the title
windows-sys dependencies on Windows targets and fix UTF-8 terminal output
|
We'll get this merged once the intake and attribution process is in place, ideally early next week. |
|
Some of the other/older PRs required the "ready-to-import" label. Is the same still valid, or is a new system of intake/attribution on the way, which you're referring to? |
|
This is the intake system and the label can only be added by mainainers. We're getting close to having the first ones merged. Hang in there, many people working beind the scenes to get this up and running :) |
Cool, cool, thanks a lot for the heads up! |
epic-lore-bot
Bot
added
imported
|
Imported as Lore CR-220. |
…inal output Part of [cross-platform build portability](#77). Fixes #43 Fixes #30 1. Four crates listed `windows-sys` under `[dependencies]` instead of `[target.'cfg(target_family = "windows")'.dependencies]`, causing build failures on non-x86_64 Linux architectures. This moves them under the right (Windows) targets. 2. The Windows console also defaulted to a legacy codepage on many configurations, causing non-ASCII characters to display as mojibake in pager-backed commands like `lore history`. So to fix that, this also adds a `SetConsoleOutputCP(CP_UTF8)` call at the CLI startup. ``` Imported-PR: #45 Imported-From: cd4ee3c Imported-Base: a00b1c4 Imported-Merge: 2a9be63 Imported-Author: subhramit (subhramit) GH-URL: #45 ``` Lore-RevId: 321 Lore-Signature: e3bb6d1e2ca4ef66c89089fe7841c8585807b524e0b9cf5d49e49ce4d64772a1
|
Closed by mirrored commit 80d8197. |
3 participants
Part of cross-platform build portability.
Fixes #43
Fixes #30
windows-sysunder[dependencies]instead of[target.'cfg(target_family = "windows")'.dependencies], causing build failures on non-x86_64 Linux architectures. This moves them under the right (Windows) targets.lore history. So to fix that, this also adds aSetConsoleOutputCP(CP_UTF8)call at the CLI startup.