lore-aws: remove legacy ENABLE_QUERY_PAGINATION tech debt - #55
Open
subbareddypalagiri wants to merge 1 commit into
Open
lore-aws: remove legacy ENABLE_QUERY_PAGINATION tech debt#55subbareddypalagiri wants to merge 1 commit into
subbareddypalagiri wants to merge 1 commit into
Conversation
mjansson
changed the title
Collaborator
|
I think this makes sense, @peter-lockhart-pub wdyt? |
subbareddypalagiri
force-pushed
the
refactor-pagination-v3
branch
2 times, most recently
from
July 7, 2026 17:36
83d99cd to
829796f
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy LORE_ENABLE_QUERY_PAGINATION feature flag and makes DynamoDB query pagination behavior unconditional, reflecting that the pagination logic is now considered stable.
Changes:
- Removed the
ENABLE_QUERY_PAGINATIONLazyLockenv-var flag plumbing. - Hardcoded the pagination follow-up query to always occur when
last_evaluated_keyindicates more pages (subject to existing limit/count conditions).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
70
to
72
| pub const METRICS_ACCUMULATION_OPERATION_LATENCY_METRIC_NAME: &str = | ||
| "accumulation_operation_duration"; | ||
|
|
subbareddypalagiri
force-pushed
the
refactor-pagination-v3
branch
from
July 7, 2026 18:16
829796f to
5dc1625
Compare
Signed-off-by: Palagiri Subba Reddy <subbareddy123sub@gmail.com>
subbareddypalagiri
force-pushed
the
refactor-pagination-v3
branch
from
July 7, 2026 18:27
5dc1625 to
a75602a
Compare
peter-lockhart-pub
approved these changes
Jul 27, 2026
peter-lockhart-pub
left a comment
peter-lockhart-pub
left a comment
Collaborator
There was a problem hiding this comment.
Thanks yes we can remove this
Collaborator
|
@subbareddypalagiri Could you clean up the clippy failure (unused import etc)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up legacy pagination flag and hardcoded the pagination logic since it is stable.
Signed-off-by: Palagiri Subba Reddy subbareddy123sub@gmail.com