feat(turbovault): fix batch_execute MCP schema with typed input model#8
Merged
nicholasjpaterno merged 1 commit intoEpistates:mainfrom Apr 6, 2026
Merged
feat(turbovault): fix batch_execute MCP schema with typed input model#8nicholasjpaterno merged 1 commit intoEpistates:mainfrom
nicholasjpaterno merged 1 commit intoEpistates:mainfrom
Conversation
replace batch_execute input from untyped JSON values to a schema-friendly BatchOperationInput enum derive JsonSchema for MCP tool generation and keep serde-tagged operation variants convert MCP-facing BatchOperationInput values into internal BatchOperation before execution remove manual serde_json::Value parsing loop in batch_execute add schemars dependency wiring needed for schema generation keep existing transactional behavior and empty-operations validation unchanged
Contributor
|
@slikts Thanks for opening this PR, I’m taking a look now! |
Contributor
|
@slikts thanks for this! I'm merging this as is, I'm going to fast follow with a few small changes and we'll get this shipped asap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loosely-typed batch operations were causing ChatGPT to fail like this when adding the server: "Invalid schema for function 'batch_execute': In context=('properties', 'operations'), array schema items is not an object." I also tested in Claude, but it worked without errors there, so it apparently depends on how permissive the JSON schema parsing is for any particular client.