feat(contracts): add batch credential operations for institutions - #231
Merged
jobbykings merged 3 commits intoJul 29, 2026
Conversation
- Fix CredentialRegistry struct: PackedTimestamps to issued_at/expires_at - Add batch_issue, batch_revoke, batch_renew with partial failure handling - Add configurable max batch size (default 100) - Create credential_registry_test.rs with 27 tests covering all acceptance criteria Closes Epondia#8
- Fix *credential_id dereference errors in batch_revoke_credentials and batch_update_expiration_status (Soroban Vec returns values) - Replace format! calls with build_indexed_string for no_std compat - Replace std::panic::catch_unwind with #[should_panic] attribute - Fix *id dereference in test batch renew loop - Update set_timestamp to ledger().get()/set() for Soroban SDK 20.x - Add Copy + PartialEq to CredentialStatus, remove conflicting Eq - Split test_set_max_batch_size into config + panic-assertion tests - Rewrite PR_BODY.md to accurately describe batch credential ops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CredentialRegistry struct: PackedTimestamps to issued_at/expires_at
Add batch_issue, batch_revoke, batch_renew with partial failure handling
Add configurable max batch size (default 100)
Create credential_registry_test.rs with 27 tests covering all acceptance criteria
Closes #8
Description
Related Issue
Closes #
Type of Change
Packages Affected
contracts/(Soroban / Rust)backend/(Node / Express)frontend/(Next.js)docs/How Has This Been Tested?
Checklist
Breaking Changes
None
Additional Notes / Screenshots
closes#8