fix(docker): align GLIBC versions and add mistralrs binary#1976
Open
glaziermag wants to merge 4 commits intoEricLBuehler:masterfrom
Open
fix(docker): align GLIBC versions and add mistralrs binary#1976glaziermag wants to merge 4 commits intoEricLBuehler:masterfrom
glaziermag wants to merge 4 commits intoEricLBuehler:masterfrom
Conversation
Code Metrics Report━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Language Files Lines Code Comments Blanks ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ C Header 5 305 210 52 43 CSS 2 1181 1036 34 111 CUDA 46 13344 10109 1500 1735 Dockerfile 1 39 22 8 9 HTML 2 235 197 14 24 JavaScript 16 3546 2676 482 388 Jinja2 7 694 656 5 33 JSON 21 409 406 0 3 Makefile 1 6 5 0 1 Metal Shading Lan| 31 11672 9033 1063 1576 PowerShell 1 300 227 30 43 Python 119 8050 6579 405 1066 Shell 2 424 274 92 58 Plain Text 3 3723 0 2413 1310 TOML 27 1290 1124 35 131 YAML 3 25 23 2 0 ───────────────────────────────────────────────────────────────────────────────── Jupyter Notebooks 3 122 83 23 16 |- Markdown 1 60 30 22 8 |- Python 1 122 113 1 8 (Total) 304 226 46 32 ───────────────────────────────────────────────────────────────────────────────── Markdown 98 10471 0 7674 2797 |- BASH 48 708 535 107 66 |- JSON 16 666 666 0 0 |- PowerShell 2 2 2 0 0 |- Python 19 740 563 83 94 |- Rust 46 1826 1519 51 256 |- TOML 6 207 164 0 43 |- YAML 2 9 8 1 0 (Total) 14629 3457 7916 3256 ───────────────────────────────────────────────────────────────────────────────── Rust 524 221303 194707 6100 20496 |- Markdown 339 8383 451 6878 1054 (Total) 229686 195158 12978 21550 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Total 912 289862 231418 27075 31369 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ |
EricLBuehler
requested changes
Mar 21, 2026
Owner
EricLBuehler
left a comment
There was a problem hiding this comment.
Hi @glaziermag! Just 1 merge conflict it looks like.
Contributor
Author
|
Resolved the merge conflict in .typos.toml. Everything looks good to go now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1948 by substituting rust:latest with rust:1-bookworm to align builder and runtime GLIBC versions, and adding a step to copy the mistralrs CLI binary into the final image.