Fix Responses API background=true + stream=true panic (#1945)#2068
Open
glaziermag wants to merge 1 commit intoEricLBuehler:masterfrom
Open
Fix Responses API background=true + stream=true panic (#1945)#2068glaziermag wants to merge 1 commit intoEricLBuehler:masterfrom
glaziermag wants to merge 1 commit intoEricLBuehler:masterfrom
Conversation
1bf58be to
5cd2631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1945
(Alternative to closed PR #1989 which aggressively disables streams).
Description
This fixes a hard background thread panic when hitting the
/v1/responsesendpoint withbackground=trueandstream=true.The endpoint spawned a background Tokio worker which polled its async
mpscreceiver using a naive single-shotmatch bg_rx.recv().await. Whenstream=truewas provided, the underlying core text pipeline correctly emittedResponse::Chunk(...)payloads. Because the background receiver wasn't looping, it instantly aborted withUnexpected response typeupon encountering the first stream chunk.This PR wraps the receiver in a
while letloop to sequentially bypass stream events in the background while accurately preserving terminalDone,ModelError, orValidationErrorstates.Before vs. After Ground Truth
Before Logs (Failing Baseline)
After Logs (Graceful Handling)
To prove the core engine correctly bypasses chunks and accurately digests terminal boundaries, I intentionally triggered an internal dimension bounds assertion in the testing sandbox.