Skip to content

Document how to reply to channel requests - #381

Merged
Eugeny merged 1 commit into
Eugeny:mainfrom
qsantos:doc-channel-success
Nov 17, 2024
Merged

Document how to reply to channel requests#381
Eugeny merged 1 commit into
Eugeny:mainfrom
qsantos:doc-channel-success

Conversation

@qsantos

@qsantos qsantos commented Nov 17, 2024

Copy link
Copy Markdown
Contributor

See #156.

Using Rust typing system would be less error-prone. Maybe the pty-req case in server_read_authenticated could handle it in two ways:

  • call Handle::channel_success or Handle::channel_failure depending on the value returned by the handler;
  • always call Handle::channel_successafter calling the handler, assuming that, if the user callsHandle::channel_failure` in the handler, it will have priority; feels very hacky though.

@qsantos

qsantos commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

Regarding the second part of my comment, I just realized that this is what #348 tries to do.

@Eugeny

Eugeny commented Nov 17, 2024

Copy link
Copy Markdown
Owner

Thanks! @all-contributors add @qsantos for docs

@Eugeny
Eugeny merged commit 2dca3c6 into Eugeny:main Nov 17, 2024
@allcontributors

Copy link
Copy Markdown
Contributor

@Eugeny

I've put up a pull request to add @qsantos! 🎉

@qsantos
qsantos deleted the doc-channel-success branch November 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants