Document how to reply to channel requests - #381
Merged
Conversation
Contributor
Author
|
Regarding the second part of my comment, I just realized that this is what #348 tries to do. |
Owner
|
Thanks! @all-contributors add @qsantos for docs |
Contributor
|
I've put up a pull request to add @qsantos! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #156.
Using Rust typing system would be less error-prone. Maybe the
pty-reqcase inserver_read_authenticatedcould handle it in two ways:Handle::channel_successorHandle::channel_failuredepending on the value returned by the handler;after calling the handler, assuming that, if the user callsHandle::channel_failure` in the handler, it will have priority; feels very hacky though.