Add TCP_NODELAY option for client - #551
Merged
Merged
Conversation
Owner
|
Thank you! |
Owner
|
@all-contributors add @tom-90 for code |
Contributor
|
I've put up a pull request to add @tom-90! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
nodelayoption to the russh client implementation, similar to a previous PR #435 that did this for the server implementation.While using Warpgate as a jumphost between my DB server and my local system, I noticed a large performance impact when executing SQL queries sequentially due to high latency. Warpgate was about twice as slow in my test workload, compared to SSH directly to the server. After testing with
russhitself, I found that by enabling this option, I could get on par performance with normal SSH.After the next release of russh happens, I'd like to contribute some changes to Warpgate itself as well, to allow enabling
nodelayfor it's SSH server- and client-side via the config.