feat: adhere to ssh_config more strictly - #570
Merged
Merged
Conversation
`ssh_config` allows multiple `Host` patterns to match a provided hostname. When multiple blocks match, the first value of any `key` is used. Furthermore, some host patterns can be negated, in which case, when a host matches that block is ignored entirely. Also, `IdentityFile` is a bit different from other parameters: every instance adds a value to the list of files. This PR adds a more strict parsing to config files into an `SshConfig` struct which can then be queried for a specific host. The configuration is merged according to the rules above. The new types remain private to the config module, but they could eventually be made public so clients can implement more ssh2 features.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssh_configallows multipleHostpatterns to match a provided hostname. When multiple blocks match, the first value of anykeyis used.Furthermore, some host patterns can be negated, in which case, when a host matches that block is ignored entirely.
Also,
IdentityFileis a bit different from other parameters: every instance adds a value to the list of files.This PR adds a more strict parsing to config files into an
SshConfigstruct which can then be queried for a specific host. The configuration is merged according to the rules above.The new types remain private to the config module, but they could eventually be made public so clients can implement more ssh2 features.