fix: accept empty name-list in KEXINIT (RFC 4251 §5) - #710
Merged
Conversation
`NameList::from_encoded_string("")` previously failed with
`Error::CharacterEncoding` because `"".split(',')` yields one empty
element, which the per-name validation rejects.
RFC 4251 §5 permits a zero-length name-list. Servers that only offer
AEAD ciphers (observed: hssh_0.1.0.0) send empty `mac_algorithms`
fields, and `client::connect` would fail before the AEAD-needs-no-MAC
fallback in `negotiation.rs` could fire.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameList::from_encoded_string("")previously failed withError::CharacterEncodingbecause"".split(',')yields one emptyelement, which the per-name validation rejects.
RFC 4251 §5 permits a zero-length name-list. Servers that only offer
AEAD ciphers (observed: hssh_0.1.0.0) send empty
mac_algorithmsfields, and
client::connectwould fail before the AEAD-needs-no-MACfallback in
negotiation.rscould fire.