Skip to content

Fix Clippy and minimal-versions CI failures on Rust 1.91 #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inureyes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Clippy and minimal-versions CI failures on Rust 1.91 #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion russh/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ default = ["flate2", "aws-lc-rs", "rsa"]
# Crypto backends: enable at least one of `aws-lc-rs` or `ring`.
aws-lc-rs = ["dep:aws-lc-rs"] # Default crypto backend.
async-trait = ["dep:async-trait"]
legacy-ed25519-pkcs8-parser = ["yasna"]
legacy-ed25519-pkcs8-parser = ["yasna", "num-bigint-04"]
# Danger: 3DES cipher is insecure.
des = ["dep:des"]
# Danger: DSA algorithm is insecure.
Expand Down Expand Up @@ -63,6 +63,10 @@ md5 = "0.8"
ml-kem = "0.3"
module-lattice = "0.2"
num-bigint = { version = "0.5", features = ["rand_0_10"] }
# `yasna` accepts any num-bigint 0.4; only listed to raise the floor, because
# a cargo-minimal-versions failure below 0.4.6 resolves `div_ceil` to the
# inherent `u64::div_ceil` instead of `Integer::div_ceil`.
num-bigint-04 = { package = "num-bigint", version = "0.4.6", optional = true }
p256 = { version = "0.14", features = ["ecdh"] }
p384 = { version = "0.14", features = ["ecdh"] }
p521 = { version = "0.14", features = ["ecdh"] }
Expand Down
8 changes: 7 additions & 1 deletion russh/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
clippy::indexing_slicing,
clippy::panic
)]
#![allow(clippy::single_match, clippy::upper_case_acronyms)]
// Rust 1.91 extended `collapsible_if` to suggest let-chains, which rustfmt
// does not yet format; revisit once it does.
#![allow(
clippy::collapsible_if,
clippy::single_match,
clippy::upper_case_acronyms
)]
#![allow(macro_expanded_macro_exports_accessed_by_absolute_paths)]
// length checked
// Copyright 2016 Pierre-Étienne Meunier
Expand Down
Loading