fix(ce-babysit-pr): keep stale-computation degrade off the settle clock - #1568
Open
saurabhkagent-lab wants to merge 2 commits into
Open
Conversation
The 600s race-to-stale-computation flip mutated base identity and set merge_computation_stale. Hashing those presentation fields reset last_change_at and added a synthetic settle delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stale-computationis a presentation of a still-stableracecandidate. Hashing the mutatedbase.identityandmerge_computation_staleflag resetlast_change_at, adding a synthetic +300s settle before merge-ready.Normalize those presentation fields out of the settle signature. Genuine identity transitions (
probe-error/race/mergeability-pending/current) still reset the clock.Validation
bun test tests/ce-babysit-pr-snapshot.test.ts— 165 passbun run release:validate— in sync_settle_base,last_change_atjumps to now on the degrade tickCloses #1562
Security Disclosure
No security-relevant changes.
Agent Disclosure