fix(ce-setup): detect leftover Codex tool-map sentinels - #1570
fix(ce-setup): detect leftover Codex tool-map sentinels#1570saurabhkagent-lab wants to merge 9 commits into
Conversation
Native Codex install no longer needs the Bun-era AGENTS.md tool map, but ce-setup still reported healthy when the block remained and Codex could skip ce-code-review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a630c109f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Isolate CODEX_HOME in check-health fixtures so host installs cannot hide or fake the leftover tool-map warning.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fc537d338
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Named-profile copies under ~/.codex/profiles are still scanned. The default root AGENTS.md is not the current session.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79b222fd37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Marketplace installs do not include docs/install/upgrading.md. Point the health warning at a skill-local reference instead.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46d051f92f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Independent grep treated END-then-BEGIN as a removable map even though removeCodexAgentsToolMapBlock would leave the file unchanged. Warn only when the first BEGIN precedes its END.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aef3b3910d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Platform-variable convention requires ${CODEX_HOME:-...}; bare
$CODEX_HOME failed skill-conventions CI.
First-occurrence END hid a removable BEGIN/END block later in the file. Warn and strip from the first BEGIN through the next END after it.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63105ee315
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Substring search treated inline documentation of both markers as a removable block. Warn and strip only when each sentinel is its own line.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d03f74236
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The upgrade paste still told agents to delete whenever both marker strings occurred. Match the skill-local guide: standalone lines and a BEGIN with a later END.
|
Thanks for this — the gap is real and I reproduced it. I'm closing this rather than asking for another round, and I want to be straight about why. The detection condition here is one thing: a standalone BEGIN line followed by a standalone END line. Over seven review rounds it became 58 added lines in Three things I'd have had to change regardless of size:
One more thing worth separating: this doesn't close #1559. The failure that issue actually reports lives in Replacement PR is coming — same premise, the condition instead of the cases, and your |
|
Replacement is up: #1577. |
2 participants
Summary
ce-setupreported a healthy Codex environment even when the retired<!-- BEGIN COMPOUND CODEX TOOL MAP -->block remained in$CODEX_HOME/AGENTS.md. That mapping is known to make Codex skipce-code-review.check-healthnow scans$CODEX_HOME/AGENTS.mdand profile copies for both sentinels and points atdocs/install/upgrading.md. Out of scope: changingce-workskip phrases or auto-stripping the file.Validation
bun test tests/skills/ce-setup-check-health.test.ts— 57 passbun run release:validate— in syncCloses #1559
Security Disclosure
No security-relevant changes. The check only reads AGENTS.md for exact sentinels.
Agent Disclosure