fix: stop repeated review invariant rounds - #1579
Closed
mura0319 wants to merge 1 commit into
Closed
Conversation
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invariant_keyをpush済みHEADごとに記録しますneeds-humanへ切り替え、レビュー修正の非収束を止めますapproval:codexを追加し、現在HEADへのCodex承認を受けるまでready判定を保留します@codex review依頼、承認待機中の無駄なwake防止、Codex投稿者の厳密判定を追加しますCloses #1575
User-visible behavior
approval:codex指定時は、現在HEADに対するCodexの明示承認だけで完了しますVerification
bun test tests/ce-babysit-pr-contract.test.ts tests/ce-babysit-pr-snapshot.test.ts tests/skills/ce-babysit-pr-convergence-contract.test.ts: 218 passedbun run test: 3,651 passed, 1 skipped, 0 failedbun run release:validate: passedpython3 -m py_compile skills/ce-babysit-pr/scripts/pr-snapshot: passedgit diff --check: passedLimitations
approval:codexはinteractive mode専用で、mode:pipelineでは拒否しますSecurity Disclosure
approval:codexの承認判定はfail-closedです。コメント本文から投稿者を推測せず、既知のCodex connector login、現在HEAD、依頼後のserver timestamp、明示承認をすべて検証します。Agent Disclosure
Codex CLI · GPT-5が実装、テスト、レビュー対応の大部分を行いました。